Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: runtime/vm/intermediate_language.h

Issue 1148943004: VM: Fix bugs with missing deoptimization environment and int32x4 constructor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/typed_data.dart ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 6290b00ccb537ab43acdef5d5be30cd4bd536c3c..1216a6ad5ed02ca33b40921d1b464b18b9f0f72d 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -4907,11 +4907,7 @@ class UnboxUint32Instr : public UnboxInteger32Instr {
ASSERT(is_truncating());
}
- virtual bool CanDeoptimize() const {
- ASSERT(is_truncating());
- return (value()->Type()->ToCid() != kSmiCid)
- && (value()->Type()->ToCid() != kMintCid);
- }
+ virtual bool CanDeoptimize() const;
virtual void InferRange(RangeAnalysis* analysis, Range* range);
@@ -6228,7 +6224,7 @@ class Int32x4ConstructorInstr : public TemplateDefinition<4, NoThrow, Pure> {
virtual Representation RequiredInputRepresentation(intptr_t idx) const {
ASSERT((idx >= 0) && (idx < 4));
- return kUnboxedUint32;
+ return kUnboxedInt32;
}
virtual intptr_t DeoptimizationTarget() const {
« no previous file with comments | « runtime/lib/typed_data.dart ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698