Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 1148943004: VM: Fix bugs with missing deoptimization environment and int32x4 constructor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 47e7dab5dd17252dab67b347c45110feb3f8fa34..6f29fd07ead0e606d566bf7f24d4cae293822224 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -1257,6 +1257,18 @@ bool UnboxInt32Instr::CanDeoptimize() const {
}
+bool UnboxUint32Instr::CanDeoptimize() const {
+ ASSERT(is_truncating());
+ if ((value()->Type()->ToCid() == kSmiCid) ||
+ (value()->Type()->ToCid() == kMintCid)) {
+ return false;
+ }
+ // Check input value's range.
+ Range* value_range = value()->definition()->range();
+ return !RangeUtils::Fits(value_range, RangeBoundary::kRangeBoundaryInt64);
+}
+
+
bool BinaryInt32OpInstr::CanDeoptimize() const {
switch (op_kind()) {
case Token::kBIT_AND:
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698