Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 1148943004: VM: Fix bugs with missing deoptimization environment and int32x4 constructor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 3292 matching lines...) Expand 10 before | Expand all | Expand 10 after
3303 const intptr_t value_cid = value()->Type()->ToCid(); 3303 const intptr_t value_cid = value()->Type()->ToCid();
3304 const Register out = locs()->out(0).reg(); 3304 const Register out = locs()->out(0).reg();
3305 const Register value = locs()->in(0).reg(); 3305 const Register value = locs()->in(0).reg();
3306 Label* deopt = CanDeoptimize() ? 3306 Label* deopt = CanDeoptimize() ?
3307 compiler->AddDeoptStub(GetDeoptId(), ICData::kDeoptUnboxInteger) : NULL; 3307 compiler->AddDeoptStub(GetDeoptId(), ICData::kDeoptUnboxInteger) : NULL;
3308 3308
3309 if (value_cid == kSmiCid) { 3309 if (value_cid == kSmiCid) {
3310 __ SmiUntag(out, value); 3310 __ SmiUntag(out, value);
3311 } else if (value_cid == kMintCid) { 3311 } else if (value_cid == kMintCid) {
3312 __ LoadFieldFromOffset(out, value, Mint::value_offset(), PP); 3312 __ LoadFieldFromOffset(out, value, Mint::value_offset(), PP);
3313 } else if (!CanDeoptimize()) {
3314 // Type information is not conclusive, but range analysis found
3315 // the value to be in int64 range. Therefore it must be a smi
3316 // or mint value.
3317 ASSERT(is_truncating());
3318 Label done;
3319 __ SmiUntag(out, value);
3320 __ TestImmediate(value, kSmiTagMask, PP);
3321 __ b(&done, EQ);
3322 __ LoadFieldFromOffset(out, value, Mint::value_offset(), PP);
3323 __ Bind(&done);
3313 } else { 3324 } else {
3314 Label done; 3325 Label done;
3315 __ SmiUntag(out, value); 3326 __ SmiUntag(out, value);
3316 __ TestImmediate(value, kSmiTagMask, PP); 3327 __ TestImmediate(value, kSmiTagMask, PP);
3317 __ b(&done, EQ); 3328 __ b(&done, EQ);
3318 __ CompareClassId(value, kMintCid, PP); 3329 __ CompareClassId(value, kMintCid, PP);
3319 __ b(deopt, NE); 3330 __ b(deopt, NE);
3320 __ LoadFieldFromOffset(out, value, Mint::value_offset(), PP); 3331 __ LoadFieldFromOffset(out, value, Mint::value_offset(), PP);
3321 __ Bind(&done); 3332 __ Bind(&done);
3322 } 3333 }
(...skipping 2323 matching lines...) Expand 10 before | Expand all | Expand 10 after
5646 1, 5657 1,
5647 locs()); 5658 locs());
5648 __ Drop(1); 5659 __ Drop(1);
5649 __ Pop(result); 5660 __ Pop(result);
5650 } 5661 }
5651 5662
5652 5663
5653 } // namespace dart 5664 } // namespace dart
5654 5665
5655 #endif // defined TARGET_ARCH_ARM64 5666 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698