Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: runtime/lib/typed_data.dart

Issue 1148943004: VM: Fix bugs with missing deoptimization environment and int32x4 constructor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // patch classes for Int8List ..... Float64List and ByteData implementations. 5 // patch classes for Int8List ..... Float64List and ByteData implementations.
6 6
7 import "dart:_internal"; 7 import "dart:_internal";
8 import 'dart:math' show Random; 8 import 'dart:math' show Random;
9 9
10 patch class Int8List { 10 patch class Int8List {
(...skipping 1248 matching lines...) Expand 10 before | Expand all | Expand 10 after
1259 1259
1260 _Uint32Array _createList(int length) { 1260 _Uint32Array _createList(int length) {
1261 return _new(length); 1261 return _new(length);
1262 } 1262 }
1263 1263
1264 int _getIndexedUint32(int index) { 1264 int _getIndexedUint32(int index) {
1265 return _getUint32(index * Uint32List.BYTES_PER_ELEMENT); 1265 return _getUint32(index * Uint32List.BYTES_PER_ELEMENT);
1266 } 1266 }
1267 1267
1268 void _setIndexedUint32(int index, int value) { 1268 void _setIndexedUint32(int index, int value) {
1269 _setInt32(index * Uint32List.BYTES_PER_ELEMENT, value); 1269 _setUint32(index * Uint32List.BYTES_PER_ELEMENT, value);
1270 } 1270 }
1271 1271
1272 static _Uint32Array _new(int length) native "TypedData_Uint32Array_new"; 1272 static _Uint32Array _new(int length) native "TypedData_Uint32Array_new";
1273 } 1273 }
1274 1274
1275 1275
1276 class _Int64Array extends _TypedList with _IntListMixin implements Int64List { 1276 class _Int64Array extends _TypedList with _IntListMixin implements Int64List {
1277 // Factory constructors. 1277 // Factory constructors.
1278 1278
1279 factory _Int64Array(int length) { 1279 factory _Int64Array(int length) {
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
1933 1933
1934 Uint32List _createList(int length) { 1934 Uint32List _createList(int length) {
1935 return new Uint32List(length); 1935 return new Uint32List(length);
1936 } 1936 }
1937 1937
1938 int _getIndexedUint32(int index) { 1938 int _getIndexedUint32(int index) {
1939 return _getUint32(index * Uint32List.BYTES_PER_ELEMENT); 1939 return _getUint32(index * Uint32List.BYTES_PER_ELEMENT);
1940 } 1940 }
1941 1941
1942 void _setIndexedUint32(int index, int value) { 1942 void _setIndexedUint32(int index, int value) {
1943 _setInt32(index * Uint32List.BYTES_PER_ELEMENT, value); 1943 _setUint32(index * Uint32List.BYTES_PER_ELEMENT, value);
1944 } 1944 }
1945 1945
1946 static _ExternalUint32Array _new(int length) native 1946 static _ExternalUint32Array _new(int length) native
1947 "ExternalTypedData_Uint32Array_new"; 1947 "ExternalTypedData_Uint32Array_new";
1948 } 1948 }
1949 1949
1950 1950
1951 class _ExternalInt64Array extends _TypedList with _IntListMixin implements Int64 List { 1951 class _ExternalInt64Array extends _TypedList with _IntListMixin implements Int64 List {
1952 // Factory constructors. 1952 // Factory constructors.
1953 1953
(...skipping 1666 matching lines...) Expand 10 before | Expand all | Expand 10 after
3620 return value; 3620 return value;
3621 } 3621 }
3622 return object; 3622 return object;
3623 } 3623 }
3624 3624
3625 3625
3626 _newRangeError(int index, int length) { 3626 _newRangeError(int index, int length) {
3627 String message = "$index must be in the range [0..$length)"; 3627 String message = "$index must be in the range [0..$length)";
3628 return new RangeError(message); 3628 return new RangeError(message);
3629 } 3629 }
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698