VM: Fix bugs with missing deoptimization environment and int32x4 constructor

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bit_vector.h"
 #include "vm/constant_propagator.h"
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
@@ skipping 1239 matching lines @@
   } else if ((kSmiBits < 32) && value()->Type()->IsInt()) {
     // Note: we don't support truncation of Bigint values.
     return !RangeUtils::Fits(value()->definition()->range(),
                              RangeBoundary::kRangeBoundaryInt32);
   } else {
     return true;
   }
 }
 
 
+bool UnboxUint32Instr::CanDeoptimize() const {
+  ASSERT(is_truncating());
+  if ((value()->Type()->ToCid() == kSmiCid) ||
+      (value()->Type()->ToCid() == kMintCid)) {
+    return false;
+  }
+  // Check input value's range.
+  Range* value_range = value()->definition()->range();
+  if (value_range != NULL &&

[Vyacheslav Egorov (Google), 2015/05/27 16:17:35]

no need for != NULL check. Fits does it for you (it calls IsUnknown which checks
for NULL)

you can just

return !RangeUtils::Fits(..., RangeBoundary::kRangeBoundaryInt64)

On the other hand RangeUtils::Fits(range, RangeBoundary::kRangeBoundaryInt64) is
equivalent to !Range::IsUnknown(range) because we never assign infinity ranges
to instructions, we only use them during range calculations. 

[Florian Schneider, 2015/05/28 08:11:09]

Done.

+      RangeUtils::Fits(value_range, RangeBoundary::kRangeBoundaryInt64)) {
+    return false;
+  }
+  return true;
+}
+
+
 bool BinaryInt32OpInstr::CanDeoptimize() const {
   switch (op_kind()) {
     case Token::kBIT_AND:
     case Token::kBIT_OR:
     case Token::kBIT_XOR:
       return false;
 
     case Token::kSHR:
       return false;
 
@@ skipping 2329 matching lines @@
     case Token::kTRUNCDIV: return 0;
     case Token::kMOD: return 1;
     default: UNIMPLEMENTED(); return -1;
   }
 }
 
 
 #undef __
 
 }  // namespace dart