Oilpan: more lazy sweep ASan exemptions.

Oilpan: more lazy sweep ASan exemptions.

Annotate the Timer methods called upon by sharedTimerFiredInternal()
as exempted by ASan checks also.

TBR=haraken
BUG=420515
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195656

[sof, 2015-05-20 21:48:16]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-05-20 21:48:16]

please take a look.

the annotation support is primitive, another round of them.

sending it along right away; anyone should feel free to jump in and add more,
should the bot still report benign failures.

[sof, 2015-05-20 21:48:26]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-05-20 21:48:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148943003/1

[haraken, 2015-05-20 22:27:26]

LGTM

https://codereview.chromium.org/1148943003/diff/1/Source/platform/Timer.h
File Source/platform/Timer.h (right):

https://codereview.chromium.org/1148943003/diff/1/Source/platform/Timer.h#new...
Source/platform/Timer.h:65: double repeatInterval() const { return
m_repeatInterval; }

I'm a bit afraid that this function is inlined in Release builds, meaning that
we might need to add NO_LAZY_SWEEP_SANITIZE_ADDRESS to the caller sites of this
function.

[commit-bot: I haz the power, 2015-05-21 01:17:59]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195656

[sof, 2015-05-21 05:31:36]

This annotate-the-world scheme is rather boring, some more coming..

https://codereview.chromium.org/1148943003/diff/1/Source/platform/Timer.h
File Source/platform/Timer.h (right):

https://codereview.chromium.org/1148943003/diff/1/Source/platform/Timer.h#new...
Source/platform/Timer.h:65: double repeatInterval() const { return
m_repeatInterval; }
On 2015/05/20 22:27:26, haraken wrote:
> 
> I'm a bit afraid that this function is inlined in Release builds, meaning that
> we might need to add NO_LAZY_SWEEP_SANITIZE_ADDRESS to the caller sites of
this
> function.

Maybe so. I don't know what it does, but if ASan doesn't restrict inlining, I
would expect/hope that annotations like this carry over across to the inline
site.