Use the correct URL for ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY errors.

Use the correct URL for ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY errors.

BUG=490260, 490240
TEST=as in bug

Committed: https://crrev.com/aa9abe7692a3ee99b69811594938d97cb180351e
Cr-Commit-Position: refs/heads/master@{#330799}

[Avi (use Gerrit), 2015-05-20 18:21:21]

avi@chromium.org changed reviewers:
+ brettw@chromium.org

[Avi (use Gerrit), 2015-05-20 18:21:22]

Quick fix.

[Avi (use Gerrit), 2015-05-20 18:26:04]

On 2015/05/20 18:21:22, Avi wrote:
> Quick fix.

agl has this in https://codereview.chromium.org/1149733002/.

[agl, 2015-05-20 18:26:07]

agl@chromium.org changed reviewers:
+ agl@chromium.org

[agl, 2015-05-20 18:26:08]

LGTM.

(Duplicate of https://codereview.chromium.org/1149733002, which I'll close.)

[Avi (use Gerrit), 2015-05-20 18:26:43]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-05-20 18:27:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148943002/1

[Avi (use Gerrit), 2015-05-20 18:28:46]

The CQ bit was unchecked by avi@chromium.org

[brettw, 2015-05-20 19:39:15]

The linked page seems to have nothing to do with the error in question. If I'm
understanding the error, it's a weak SSL key that we reject for some reason, but
the help page is about how to set up group policy.

Are we sure this is correct? Would no link here be better?

[Avi (use Gerrit), 2015-05-20 19:47:04]

On 2015/05/20 19:39:15, brettw wrote:
> The linked page seems to have nothing to do with the error in question. If I'm
> understanding the error, it's a weak SSL key that we reject for some reason,
but
> the help page is about how to set up group policy.
> 
> Are we sure this is correct? Would no link here be better?

Pardon?

The link is
https://www.chromium.org/administrators/err_ssl_weak_server_ephemeral_dh_key
which is about weak DH keys, and has nothing to do with group policy.

Can you clarify what page you're looking at?

[brettw, 2015-05-20 19:50:38]

Oh, I didn't follow the line wrap. LGTM

[Avi (use Gerrit), 2015-05-20 19:52:41]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2015-05-20 19:52:41]

The patchset sent to the CQ was uploaded after l-g-t-m from agl@chromium.org
Link to the patchset: https://codereview.chromium.org/1148943002/#ps20001
(title: "www")

[commit-bot: I haz the power, 2015-05-20 19:53:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148943002/20001

[commit-bot: I haz the power, 2015-05-20 20:57:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-20 20:58:11]

Patchset 2 (id:??) landed as
https://crrev.com/aa9abe7692a3ee99b69811594938d97cb180351e
Cr-Commit-Position: refs/heads/master@{#330799}

[veeraganurpaccs_gmail.com, 2015-07-16 14:28:56]

what i have to do for that error please explain


On Wednesday, May 20, 2015 at 11:51:23 PM UTC+5:30, Avi Drissman wrote:
>
> Reviewers: brettw, 
>
> Message: 
> Quick fix. 
>
> Description: 
> Use the correct URL for ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY errors. 
>
> BUG=490260 
> TEST=as in bug 
>
> Please review this at https://codereview.chromium.org/1148943002/ 
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master 
>
> Affected files (+1, -1 lines): 
>    M chrome/common/localized_error.cc 
>
>
> Index: chrome/common/localized_error.cc 
> diff --git a/chrome/common/localized_error.cc   
> b/chrome/common/localized_error.cc 
> index   
>
0c4ad4361e590adf71d4784a78846863e490b287..0732fca114567f97c5a0095985f7f536f22a7d02

>   
> 100644 
> --- a/chrome/common/localized_error.cc 
> +++ b/chrome/common/localized_error.cc 
> @@ -49,7 +49,7 @@ namespace { 
>   static const char kRedirectLoopLearnMoreUrl[] = 
>       "https://www.google.com/support/chrome/bin/answer.py?answer=95626"; 
>   static const char kWeakDHKeyLearnMoreUrl[] = 
> -    "http://sites.google.com/a/chromium.org/dev/" 
> +    "https://dev.chromium.org/administrators/" 
>       "err_ssl_weak_server_ephemeral_dh_key"; 
>   #if defined(OS_CHROMEOS) 
>   static const char kAppWarningLearnMoreUrl[] = 
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.