Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: mojo/services/network/public/cpp/web_socket_read_queue.h

Issue 1148913002: Fix WebSocket{Read,Write}Queue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/network/public/cpp/web_socket_read_queue.h
diff --git a/mojo/services/network/public/cpp/web_socket_read_queue.h b/mojo/services/network/public/cpp/web_socket_read_queue.h
index 27315105710a963d0521eb23d3aaffd7234bf27d..ffb7ec15db650c2cbdc068615745500ab8dfacaa 100644
--- a/mojo/services/network/public/cpp/web_socket_read_queue.h
+++ b/mojo/services/network/public/cpp/web_socket_read_queue.h
@@ -19,7 +19,7 @@ namespace mojo {
// See also: WebSocketWriteQueue
class WebSocketReadQueue {
public:
- WebSocketReadQueue(DataPipeConsumerHandle handle);
+ explicit WebSocketReadQueue(DataPipeConsumerHandle handle);
~WebSocketReadQueue();
void Read(uint32_t num_bytes, base::Callback<void(const char*)> callback);
@@ -34,7 +34,10 @@ class WebSocketReadQueue {
DataPipeConsumerHandle handle_;
common::HandleWatcher handle_watcher_;
ScopedVector<Operation> queue_;
- bool is_waiting_;
+ bool is_busy_;
+ // If non-null, the boolean it points to (allocated on the stack) will be set
+ // to true when this object is destructed.
+ bool* destructed_;
};
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698