Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1148903003: Add a basic postMessage test for <webview> in a new test suite. (Closed)

Created:
5 years, 7 months ago by lazyboy
Modified:
5 years, 7 months ago
Reviewers:
Fady Samuel, sky, lfg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a basic postMessage test for <webview> in a new test suite. The plan is to run this test in site isolation bots as well when <webview> using OOPIF CL lands. BUG=330264 Test=None Committed: https://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0 Cr-Commit-Position: refs/heads/master@{#331061}

Patch Set 1 #

Patch Set 2 : clean up a bit #

Total comments: 6

Patch Set 3 : address comments #

Total comments: 2

Patch Set 4 : check e.source == webview.contentWindow #

Messages

Total messages: 17 (5 generated)
lazyboy
5 years, 7 months ago (2015-05-21 21:40:38 UTC) #2
Fady Samuel
https://chromiumcodereview.appspot.com/1148903003/diff/20001/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js File chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js (right): https://chromiumcodereview.appspot.com/1148903003/diff/20001/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js#newcode28 chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js:28: if (data.length != 1 && data[0] !== 'pong') { ...
5 years, 7 months ago (2015-05-21 21:54:36 UTC) #4
lfg
lgtm with 2 optional nits. https://chromiumcodereview.appspot.com/1148903003/diff/20001/chrome/browser/apps/guest_view/web_view_browsertest.cc File chrome/browser/apps/guest_view/web_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/1148903003/diff/20001/chrome/browser/apps/guest_view/web_view_browsertest.cc#newcode849 chrome/browser/apps/guest_view/web_view_browsertest.cc:849: class WebViewBasicTest : public ...
5 years, 7 months ago (2015-05-21 22:49:25 UTC) #5
lazyboy
https://chromiumcodereview.appspot.com/1148903003/diff/20001/chrome/browser/apps/guest_view/web_view_browsertest.cc File chrome/browser/apps/guest_view/web_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/1148903003/diff/20001/chrome/browser/apps/guest_view/web_view_browsertest.cc#newcode849 chrome/browser/apps/guest_view/web_view_browsertest.cc:849: class WebViewBasicTest : public extensions::PlatformAppBrowserTest {}; On 2015/05/21 22:49:25, ...
5 years, 7 months ago (2015-05-21 23:31:05 UTC) #6
Fady Samuel
https://chromiumcodereview.appspot.com/1148903003/diff/40001/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js File chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js (right): https://chromiumcodereview.appspot.com/1148903003/diff/40001/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js#newcode28 chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js:28: if (data.length != 1 || data[0] !== 'pong' || ...
5 years, 7 months ago (2015-05-21 23:36:50 UTC) #7
lazyboy
https://chromiumcodereview.appspot.com/1148903003/diff/40001/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js File chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js (right): https://chromiumcodereview.appspot.com/1148903003/diff/40001/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js#newcode28 chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js:28: if (data.length != 1 || data[0] !== 'pong' || ...
5 years, 7 months ago (2015-05-22 01:45:30 UTC) #8
Fady Samuel
lgtm
5 years, 7 months ago (2015-05-22 01:48:54 UTC) #9
lazyboy
+sky for OWNERS review: testing/buildbot/chromium.fyi.json
5 years, 7 months ago (2015-05-22 01:53:41 UTC) #11
sky
LGTM
5 years, 7 months ago (2015-05-22 03:04:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148903003/60001
5 years, 7 months ago (2015-05-22 03:50:35 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-22 03:56:18 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 03:57:36 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0
Cr-Commit-Position: refs/heads/master@{#331061}

Powered by Google App Engine
This is Rietveld 408576698