runtime/lib/identical_patch.dart - Issue 11489011: Make identical an external function and make it throw in both runtimes, as they both recognize it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/identical_patch.dart

Issue 11489011: Make identical an external function and make it throw in both runtimes, as they both recognize it. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 patch bool identical(Object a, Object b) {

	6 throw new Error('Should not reach the body of identical');
	srdjan 2012/12/10 19:58:44 This should be a native call instead of throw. This should be a native call instead of throw. ngeoffray 2012/12/10 20:26:39 Any reason why? Do you mind if I land this CL (all Show quoted text On 2012/12/10 19:58:44, srdjan wrote: > This should be a native call instead of throw. Any reason why? Do you mind if I land this CL (all tests pass with the VM), and let you change it? I can change the throw and use '===' like it was before if you prefer. srdjan 2012/12/10 21:24:51 We should not mandate inlining/intrinsification of Show quoted text On 2012/12/10 20:26:39, ngeoffray wrote: > On 2012/12/10 19:58:44, srdjan wrote: > > This should be a native call instead of throw. > > Any reason why? Do you mind if I land this CL (all tests pass with the VM), and > let you change it? I can change the throw and use '===' like it was before if > you prefer. We should not mandate inlining/intrinsification of a a method in order to be able to run. Yes, land it and I will fix it on VM side. ngeoffray 2012/12/11 09:21:44 Makes sense. Show quoted text On 2012/12/10 21:24:51, srdjan wrote: > On 2012/12/10 20:26:39, ngeoffray wrote: > > On 2012/12/10 19:58:44, srdjan wrote: > > > This should be a native call instead of throw. > > > > Any reason why? Do you mind if I land this CL (all tests pass with the VM), > and > > let you change it? I can change the throw and use '===' like it was before if > > you prefer. > > We should not mandate inlining/intrinsification of a a method in order to be > able to run. Makes sense. Show quoted text > Yes, land it and I will fix it on VM side. OK, thanks Srdjan.
	7 }

OLD	NEW

« no previous file with comments | « no previous file | runtime/lib/lib_sources.gypi » ('j') | no next file with comments »