tools/dom/src/Validators.dart - Issue 1148893004: Make sanitizer tests handle IE11, where tagName can't be clobbered

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/Validators.dart

Issue 1148893004: Make sanitizer tests handle IE11, where tagName can't be clobbered (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Removing paranoia around tagName, which wasn't likely to work anyway Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/src/Validators.dart

diff --git a/tools/dom/src/Validators.dart b/tools/dom/src/Validators.dart

index 60d8f35f654ae6320fde3a73cf3c9280566b769b..572477037bad32afeedd662347e525359a5c188f 100644

--- a/tools/dom/src/Validators.dart

+++ b/tools/dom/src/Validators.dart

@@ -253,7 +253,7 @@ class _ValidatingTreeSanitizer implements NodeTreeSanitizer {

void sanitizeNode(Node node, Node parent) {

switch (node.nodeType) {

case Node.ELEMENT_NODE:

- _sanitizeUntrustedElement(node, parent);

+ _sanitizeUntrustedElement(node, parent);

break;

case Node.COMMENT_NODE:

case Node.DOCUMENT_FRAGMENT_NODE:

« no previous file with comments | « tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart ('k') | no next file » | no next file with comments »