Refactoring: Remove enum class NodeTraversalMode

Refactoring: Remove enum class NodeTraversalMode

NodeTraversalMode is an enum class which has two values and this is
currently used like a boolean value. At traversalNodesForSerialization,
if and only if this flag is DoNotEmitString, StyledMarkupAccumulator is
used. This CL removes this boolean-like enum and uses
StyledMarkupAccumulator* to represent the same condition instead.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196646

[hajimehoshi, 2015-06-05 10:33:36]

hajimehoshi@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[hajimehoshi, 2015-06-05 10:33:36]

PTAL

[tkent, 2015-06-07 23:39:02]

https://codereview.chromium.org/1148873009/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1148873009/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupSerializer.cpp:212: Node*
StyledMarkupSerializer<Strategy>::traverseNodesForSerialization(Node* startNode,
Node* pastEnd, StyledMarkupAccumulator* markupAccumulator)
If |markupAccumulator| can't be nullptr, use a reference instead of a pointer.

[yosin_UTC9, 2015-06-08 02:00:05]

https://codereview.chromium.org/1148873009/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1148873009/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupSerializer.cpp:212: Node*
StyledMarkupSerializer<Strategy>::traverseNodesForSerialization(Node* startNode,
Node* pastEnd, StyledMarkupAccumulator* markupAccumulator)
On 2015/06/07 23:39:01, tkent wrote:
> If |markupAccumulator| can't be nullptr, use a reference instead of a pointer.

|markupAcccumlator| is |nullptr| at L198. 

This patch replace |traversalMode|={EmitString, DoNotEmitString} by
|markupAcuumlator|={Instance of StyledMarkupAccumlator, nullptr}.

[tkent, 2015-06-08 02:03:29]

https://codereview.chromium.org/1148873009/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1148873009/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupSerializer.cpp:212: Node*
StyledMarkupSerializer<Strategy>::traverseNodesForSerialization(Node* startNode,
Node* pastEnd, StyledMarkupAccumulator* markupAccumulator)
On 2015/06/08 02:00:05, Yosi_UTC9 wrote:
> On 2015/06/07 23:39:01, tkent wrote:
> > If |markupAccumulator| can't be nullptr, use a reference instead of a
pointer.
> 
> |markupAcccumlator| is |nullptr| at L198. 
> 
> This patch replace |traversalMode|={EmitString, DoNotEmitString} by
> |markupAcuumlator|={Instance of StyledMarkupAccumlator, nullptr}.

Thank you.  lgtm.

[tkent, 2015-06-08 02:03:34]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-06-08 02:03:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148873009/1

[commit-bot: I haz the power, 2015-06-08 03:22:51]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196646