Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 1148873005: Parsing CSS properties for scroll snap points (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add additional tests for position parsing Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 case CSSPropertyAliasWebkitFlexFlow: return 489; 525 case CSSPropertyAliasWebkitFlexFlow: return 489;
526 case CSSPropertyAliasWebkitFlexGrow: return 490; 526 case CSSPropertyAliasWebkitFlexGrow: return 490;
527 case CSSPropertyAliasWebkitFlexShrink: return 491; 527 case CSSPropertyAliasWebkitFlexShrink: return 491;
528 case CSSPropertyAliasWebkitFlexWrap: return 492; 528 case CSSPropertyAliasWebkitFlexWrap: return 492;
529 case CSSPropertyAliasWebkitJustifyContent: return 493; 529 case CSSPropertyAliasWebkitJustifyContent: return 493;
530 case CSSPropertyAliasWebkitOpacity: return 494; 530 case CSSPropertyAliasWebkitOpacity: return 494;
531 case CSSPropertyAliasWebkitOrder: return 495; 531 case CSSPropertyAliasWebkitOrder: return 495;
532 case CSSPropertyAliasWebkitShapeImageThreshold: return 496; 532 case CSSPropertyAliasWebkitShapeImageThreshold: return 496;
533 case CSSPropertyAliasWebkitShapeMargin: return 497; 533 case CSSPropertyAliasWebkitShapeMargin: return 497;
534 case CSSPropertyAliasWebkitShapeOutside: return 498; 534 case CSSPropertyAliasWebkitShapeOutside: return 498;
535 case CSSPropertyScrollSnapType: return 499;
536 case CSSPropertyScrollSnapPointsX: return 500;
537 case CSSPropertyScrollSnapPointsY: return 501;
538 case CSSPropertyScrollSnapCoordinate: return 502;
539 case CSSPropertyScrollSnapDestination: return 503;
535 540
536 // 1. Add new features above this line (don't change the assigned numbers of the existing 541 // 1. Add new features above this line (don't change the assigned numbers of the existing
537 // items). 542 // items).
538 // 2. Update maximumCSSSampleId() with the new maximum value. 543 // 2. Update maximumCSSSampleId() with the new maximum value.
539 // 3. Run the update_use_counter_css.py script in 544 // 3. Run the update_use_counter_css.py script in
540 // chromium/src/tools/metrics/histograms to update the UMA histogram names. 545 // chromium/src/tools/metrics/histograms to update the UMA histogram names.
majidvp 2015/05/26 19:25:07 Running the script resulted in a histogram.xml whi
Timothy Loh 2015/05/27 00:54:04 I think histograms.xml is in a separate repo (not
541 546
542 case CSSPropertyInvalid: 547 case CSSPropertyInvalid:
543 ASSERT_NOT_REACHED(); 548 ASSERT_NOT_REACHED();
544 return 0; 549 return 0;
545 } 550 }
546 551
547 ASSERT_NOT_REACHED(); 552 ASSERT_NOT_REACHED();
548 return 0; 553 return 0;
549 } 554 }
550 555
551 static int maximumCSSSampleId() { return 498; } 556 static int maximumCSSSampleId() { return 503; }
552 557
553 void UseCounter::muteForInspector() 558 void UseCounter::muteForInspector()
554 { 559 {
555 UseCounter::m_muteCount++; 560 UseCounter::m_muteCount++;
556 } 561 }
557 562
558 void UseCounter::unmuteForInspector() 563 void UseCounter::unmuteForInspector()
559 { 564 {
560 UseCounter::m_muteCount--; 565 UseCounter::m_muteCount--;
561 } 566 }
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 945 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
941 { 946 {
942 // FIXME: We may want to handle stylesheets that have multiple owners 947 // FIXME: We may want to handle stylesheets that have multiple owners
943 // http://crbug.com/242125 948 // http://crbug.com/242125
944 if (sheetContents && sheetContents->hasSingleOwnerNode()) 949 if (sheetContents && sheetContents->hasSingleOwnerNode())
945 return getFrom(sheetContents->singleOwnerDocument()); 950 return getFrom(sheetContents->singleOwnerDocument());
946 return 0; 951 return 0;
947 } 952 }
948 953
949 } // namespace blink 954 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698