Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1148863002: Fix for-in for large indexes and indexes on proxies (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix for-in for large indexes and indexes on proxies BUG=v8:4130 LOG=n Committed: https://crrev.com/de23dd280980bc2ae3e8f9a5a490e65e46cfc15b Cr-Commit-Position: refs/heads/master@{#28526}

Patch Set 1 #

Patch Set 2 : Explicitly cast to uint32_t #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -41 lines) Patch
M src/elements.h View 1 chunk +2 lines, -9 lines 0 comments Download
M src/elements.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M src/objects.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +20 lines, -19 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M test/mjsunit/for-in.js View 1 chunk +12 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/proxies-for.js View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-20 15:00:41 UTC) #2
Jakob Kummerow
lgtm
5 years, 7 months ago (2015-05-20 15:17:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148863002/1
5 years, 7 months ago (2015-05-20 15:21:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/2703)
5 years, 7 months ago (2015-05-20 15:45:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148863002/40001
5 years, 7 months ago (2015-05-20 16:22:50 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-20 17:03:30 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:03:44 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/de23dd280980bc2ae3e8f9a5a490e65e46cfc15b
Cr-Commit-Position: refs/heads/master@{#28526}

Powered by Google App Engine
This is Rietveld 408576698