Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1148853010: Revert of gpu: Add GL_TEXTURE_RECTANGLE_ARB support to CopyTexSubImage2D optimization of CopyTexture. (Closed)

Created:
5 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 6 months ago
Reviewers:
dshwang, reveman, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Add GL_TEXTURE_RECTANGLE_ARB support to CopyTexSubImage2D optimization of CopyTexture. (patchset #1 id:1 of https://codereview.chromium.org/1149233005/) Reason for revert: May have caused WebGL conformance test failures on OS X; see http://crbug.com/486922 . Original issue's description: > gpu: Add GL_TEXTURE_RECTANGLE_ARB support to CopyTexSubImage2D optimization of CopyTexture. > > The availability of this extension is already limited to desktop core > profile as the only reason we need to support it is IOSurfaces on > MacOSX. > > This provides 2x performance improvement of copy operations when using > IOSurface backed GpuMemoryBuffers. > > BUG=486922 > > Committed: https://crrev.com/48514369cc66bc04ec766adf774de41d396a33ad > Cr-Commit-Position: refs/heads/master@{#333159} TBR=piman@chromium.org,dongseong.hwang@intel.com,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=486922 Committed: https://crrev.com/0e8e291d8796a70363c50a11bdef62d1a7e5550e Cr-Commit-Position: refs/heads/master@{#333187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Russell (switch to Gerrit)
5 years, 6 months ago (2015-06-06 00:35:52 UTC) #1
Created Revert of gpu: Add GL_TEXTURE_RECTANGLE_ARB support to CopyTexSubImage2D
optimization of CopyTexture.

Powered by Google App Engine
This is Rietveld 408576698