Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1148853005: [BackgroundSync] Clean up some tests (Closed)

Created:
5 years, 6 months ago by jkarlin
Modified:
5 years, 6 months ago
Reviewers:
jsbell
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BackgroundSync] Clean up some tests Cleaning up some tests to use helper functions and remove dangling pointers. It also fixes the DisabledManagerWorksAfterBrowserRestart test which wasn't initializing after creating a new manager. Committed: https://crrev.com/6988e2530e4f016e718055040a0bee9cdfe6c0f8 Cr-Commit-Position: refs/heads/master@{#333074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -43 lines) Patch
M content/browser/background_sync/background_sync_manager_unittest.cc View 11 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jkarlin
Hi Josh, can you please review this quick cleanup cl? Thanks!
5 years, 6 months ago (2015-06-05 16:43:35 UTC) #2
jsbell
lgtm
5 years, 6 months ago (2015-06-05 16:51:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148853005/1
5 years, 6 months ago (2015-06-05 16:53:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 17:01:28 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 17:02:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6988e2530e4f016e718055040a0bee9cdfe6c0f8
Cr-Commit-Position: refs/heads/master@{#333074}

Powered by Google App Engine
This is Rietveld 408576698