Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1148853004: Files.app: Disable eject button on MTP device. (Closed)

Created:
5 years, 6 months ago by yawano
Modified:
5 years, 6 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Disable eject button on MTP device. BUG=495997 TEST=manually tested; Connect MTP device and confirm that MTP volume does not have eject button. Committed: https://crrev.com/f0da152fd8af7961e00508e40ec0662f32dc8d5d Cr-Commit-Position: refs/heads/master@{#333233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 6 months ago (2015-06-05 09:41:31 UTC) #2
yoshiki
lgtm
5 years, 6 months ago (2015-06-08 02:18:43 UTC) #3
yawano
On 2015/06/08 02:18:43, yoshiki wrote: > lgtm Thank you!
5 years, 6 months ago (2015-06-08 02:22:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148853004/1
5 years, 6 months ago (2015-06-08 02:23:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-08 02:44:22 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 02:45:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0da152fd8af7961e00508e40ec0662f32dc8d5d
Cr-Commit-Position: refs/heads/master@{#333233}

Powered by Google App Engine
This is Rietveld 408576698