Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: Source/core/layout/LayoutBox.h

Issue 1148833002: Move m_pageLogicalOffset from LayoutBlock to LayoutBoxRareData. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: sizeof(LayoutBlock) has shrunk. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutBlock.cpp ('k') | Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutBox.h
diff --git a/Source/core/layout/LayoutBox.h b/Source/core/layout/LayoutBox.h
index 146126101f8070a095248e525f30b9300f03888f..82f7e9f942380f42a355da6fa57035936215623f 100644
--- a/Source/core/layout/LayoutBox.h
+++ b/Source/core/layout/LayoutBox.h
@@ -71,6 +71,8 @@ public:
// Set by LayoutBox::updatePreviousBorderBoxSizeIfNeeded().
LayoutSize m_previousBorderBoxSize;
+
+ LayoutUnit m_pageLogicalOffset;
};
class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {
@@ -454,6 +456,11 @@ public:
virtual LayoutUnit offsetFromLogicalTopOfFirstPage() const;
+ // The page logical offset is the object's offset from the top of the page in the page progression
+ // direction (so an x-offset in vertical text and a y-offset for horizontal text).
leviw_travelin_and_unemployed 2015/05/20 21:23:44 Mega-Nit-feel-free-to-ignore: I may describe the c
mstensho (USE GERRIT) 2015/05/20 21:47:32 That would have been better, but since I just move
+ LayoutUnit pageLogicalOffset() const { return m_rareData ? m_rareData->m_pageLogicalOffset : LayoutUnit(); }
+ void setPageLogicalOffset(LayoutUnit);
+
void positionLineBox(InlineBox*);
void moveWithEdgeOfInlineContainerIfNecessary(bool isHorizontal);
void markStaticPositionedBoxForLayout(bool isHorizontal, bool isInline);
« no previous file with comments | « Source/core/layout/LayoutBlock.cpp ('k') | Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698