Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: Source/core/layout/LayoutBlock.h

Issue 1148833002: Move m_pageLogicalOffset from LayoutBlock to LayoutBoxRareData. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: sizeof(LayoutBlock) has shrunk. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/layout/LayoutBlock.cpp » ('j') | Source/core/layout/LayoutBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutBlock.h
diff --git a/Source/core/layout/LayoutBlock.h b/Source/core/layout/LayoutBlock.h
index 67b040080b73063d58ee5f9e854cd31ce098a190..85bf789be8a407eb71309570c774a2e69e215c8a 100644
--- a/Source/core/layout/LayoutBlock.h
+++ b/Source/core/layout/LayoutBlock.h
@@ -200,11 +200,6 @@ public:
unsigned columnCount(ColumnInfo*) const;
LayoutRect columnRectAt(ColumnInfo*, unsigned) const;
- // The page logical offset is the object's offset from the top of the page in the page progression
- // direction (so an x-offset in vertical text and a y-offset for horizontal text).
- LayoutUnit pageLogicalOffset() const { return m_pageLogicalOffset; }
- void setPageLogicalOffset(LayoutUnit offset) { m_pageLogicalOffset = offset; }
-
// Accessors for logical width/height and margins in the containing block's block-flow direction.
LayoutUnit logicalWidthForChild(const LayoutBox& child) const { return isHorizontalWritingMode() ? child.size().width() : child.size().height(); }
LayoutUnit logicalHeightForChild(const LayoutBox& child) const { return isHorizontalWritingMode() ? child.size().height() : child.size().width(); }
@@ -456,8 +451,6 @@ protected:
LayoutObjectChildList m_children;
LineBoxList m_lineBoxes; // All of the root line boxes created for this block flow. For example, <div>Hello<br>world.</div> will have two total lines for the <div>.
- LayoutUnit m_pageLogicalOffset;
-
unsigned m_hasMarginBeforeQuirk : 1; // Note these quirk values can't be put in LayoutBlockRareData since they are set too frequently.
unsigned m_hasMarginAfterQuirk : 1;
unsigned m_beingDestroyed : 1;
« no previous file with comments | « no previous file | Source/core/layout/LayoutBlock.cpp » ('j') | Source/core/layout/LayoutBox.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698