Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1148833002: Move m_pageLogicalOffset from LayoutBlock to LayoutBoxRareData. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Move m_pageLogicalOffset from LayoutBlock to LayoutBoxRareData. This is about as rare as all the other pagination things, and, furthermore, in the future, we're going to need this piece of information in other LayoutBox derived classes than LayoutBlock, such as e.g. LayoutTableRow. R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195642

Patch Set 1 #

Patch Set 2 : sizeof(LayoutBlock) has shrunk. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M Source/core/layout/LayoutBlock.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutBox.h View 2 chunks +7 lines, -0 lines 2 comments Download
M Source/core/layout/LayoutBox.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 7 months ago (2015-05-20 13:21:28 UTC) #1
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1148833002/diff/20001/Source/core/layout/LayoutBox.h File Source/core/layout/LayoutBox.h (right): https://codereview.chromium.org/1148833002/diff/20001/Source/core/layout/LayoutBox.h#newcode460 Source/core/layout/LayoutBox.h:460: // direction (so an x-offset in vertical text ...
5 years, 7 months ago (2015-05-20 21:23:44 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/1148833002/diff/20001/Source/core/layout/LayoutBox.h File Source/core/layout/LayoutBox.h (right): https://codereview.chromium.org/1148833002/diff/20001/Source/core/layout/LayoutBox.h#newcode460 Source/core/layout/LayoutBox.h:460: // direction (so an x-offset in vertical text and ...
5 years, 7 months ago (2015-05-20 21:47:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148833002/20001
5 years, 7 months ago (2015-05-20 21:48:44 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 21:52:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195642

Powered by Google App Engine
This is Rietveld 408576698