gin/modules/file_module_provider.cc - Issue 114883003: Implement more of the JavaScript GL API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/file_module_provider.cc

Issue 114883003: Implement more of the JavaScript GL API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/file_module_provider.cc

diff --git a/gin/modules/file_module_provider.cc b/gin/modules/file_module_provider.cc

index 990dcd000c03572e52768e7d63bfeb720a44e76c..660d9b1b9ac2e2a1e60f56cc78827abc0975fce3 100644

--- a/gin/modules/file_module_provider.cc

+++ b/gin/modules/file_module_provider.cc

@@ -37,10 +37,7 @@ void AttempToLoadModule(const base::WeakPtr<Runner>& runner,

continue;

Runner::Scope scope(runner.get());

- v8::Handle<v8::Script> script = v8::Script::New(

- StringToV8(runner->isolate(), source),

- StringToV8(runner->isolate(), id));

- runner->Run(script);

+ runner->Run(source, id);

return;

}