Implement more of the JavaScript GL API.

mojo/apps/js/bindings/codec.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 define(function() {
 
   // Memory -------------------------------------------------------------------
 
   function store8(memory, pointer, val) {
     memory[pointer] = val;
@@ skipping 27 matching lines @@
   }
 
   function load32(memory, pointer) {
     return (memory[pointer + 0] <<  0) +
            (memory[pointer + 1] <<  8) +
            (memory[pointer + 2] << 16) +
            (memory[pointer + 3] << 24);
   }
 
   function load64(memory, pointer) {
-    var low = load32(memory, pointer);
-    var high = load32(memory, pointer + 4);
-    return low + high * 0x10000;
+    var low = Math.abs(load32(memory, pointer));
+    var high = Math.abs(load32(memory, pointer + 4));
+    return low + high * 0x100000000;
   }
 
   var kAlignment = 8;
 
   function align(size) {
     return size + (kAlignment - (size % kAlignment)) % kAlignment;
   }
 
   // Buffer -------------------------------------------------------------------
 
@@ skipping 30 matching lines @@
   var kStructHeaderSize = 8;
   var kMessageHeaderSize = 8;
 
   // Decoder ------------------------------------------------------------------
 
   function Decoder(memory, handles, base) {
     this.memory = memory;
     this.handles = handles;
     this.base = base;
     this.next = base;
+    this.viewU32 = new Uint32Array(
+        this.memory.buffer, 0,
+        Math.floor(this.memory.length / Uint32Array.BYTES_PER_ELEMENT));
   }
 
   Decoder.prototype.skip = function(offset) {
     this.next += offset;
   };
 
   Decoder.prototype.read8 = function() {
     var result = load8(this.memory, this.next);
     this.next += 1;
     return result;
   };
 
   Decoder.prototype.read32 = function() {
-    var result = load32(this.memory, this.next);
-    this.next += 4;
+    var result = this.viewU32[this.next / this.viewU32.BYTES_PER_ELEMENT];
+    this.next += this.viewU32.BYTES_PER_ELEMENT;
     return result;
   };
 
   Decoder.prototype.read64 = function() {
+    var low = this.read32();
+    var high = this.read32();
+    return low + high * 0x100000000;
+
     var result = load64(this.memory, this.next);
     this.next += 8;
     return result;

[abarth-chromium, 2013/12/20 04:21:02]

These last few lines are dead now.  You can probably remove them.  Once you do,
load64 won't have any callers and you can remove it too.

[Aaron Boodman, 2013/12/20 05:42:24]

Eep. Thanks.

   };
 
   Decoder.prototype.decodePointer = function() {
     // TODO(abarth): To correctly decode a pointer, we need to know the real
     // base address of the array buffer.
     var offsetPointer = this.next;
     var offset = this.read64();
     if (!offset)
       return 0;
     return offsetPointer + offset;
@@ skipping 303 matching lines @@
   exports.kMessageHeaderSize = kMessageHeaderSize;
   exports.Uint8 = Uint8;
   exports.Uint16 = Uint16;
   exports.Uint32 = Uint32;
   exports.Uint64 = Uint64;
   exports.PointerTo = PointerTo;
   exports.ArrayOf = ArrayOf;
   exports.Handle = Handle;
   return exports;
 });