Issue 114883002: Remove chrome-internal scheme, chrome::kChromeInternalScheme.

Issue 114883002: Remove chrome-internal scheme, chrome::kChromeInternalScheme. (Closed)

Created:
7 years ago by msw

Modified:
7 years ago

Reviewers:
jam

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, browser-components-watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, estade+watch_chromium.org, markusheintz_, pedrosimonetti+watch_chromium.org, Charlie Reis

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove chrome-internal scheme, chrome::kChromeInternalScheme. The chrome-internal scheme was once used to host the NTP. It's now hosted at about:newtab, aka. chrome://newtab. There's no compelling reason to support chrome-internal. BUG=6564, 327845 R=jam@chromium.org TEST=chrome-internal://foo no longer redirects to the new tab page, no one gets upset. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240819

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -71 lines)			Patch
M	chrome/browser/browsing_data/browsing_data_helper_unittest.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/content_settings/host_content_settings_map.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/history/history_service.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/toolbar/toolbar_model_unittest.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/website_settings/website_settings_utils.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/renderer/content_settings_observer.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/renderer/content_settings_observer_unittest.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/common/url_schemes.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/public/common/url_constants.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/url_constants.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/url_utils.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/114883002/1

7 years ago (2013-12-13 21:55:34 UTC) #3

Message was sent while issue was closed.

Change committed as 240819

Expand Messages | Collapse Messages