Move EventHandler from core/page/ to core/input

Move EventHandler from core/page/ to core/input

We have a input folder in core/ which keeps InputDevice information for all UIEvents,
so we decide to move  EventHandler into input/ as well.

BUG=496757
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196589

[lanwei, 2015-06-03 18:40:22]

lanwei@chromium.org changed reviewers:
+ rbyers@chromium.org, tdresser@chromium.org

[lanwei, 2015-06-03 21:56:21]

Patchset #2 (id:20001) has been deleted

[lanwei, 2015-06-03 21:56:25]

Patchset #1 (id:1) has been deleted

[lanwei, 2015-06-03 22:00:58]

Patchset #1 (id:40001) has been deleted

[tdresser, 2015-06-04 13:08:47]

Can you create a new bug for this change? It's pretty unrelated to the
InputDevice work.

LGTM with nits.

https://codereview.chromium.org/1148813007/diff/60001/Source/core/core.gypi
File Source/core/core.gypi (left):

https://codereview.chromium.org/1148813007/diff/60001/Source/core/core.gypi#o...
Source/core/core.gypi:288: 'inspector/JavaScriptCallFrame.idl',
Why this change?

https://codereview.chromium.org/1148813007/diff/60001/Source/web/tests/WebInp...
File Source/web/tests/WebInputEventConversionTest.cpp (right):

https://codereview.chromium.org/1148813007/diff/60001/Source/web/tests/WebInp...
Source/web/tests/WebInputEventConversionTest.cpp:45: #include
"core/input/InputDevice.h"
I don't think these changes belong as part of this patch.

[Rick Byers, 2015-06-04 13:15:44]

On 2015/06/04 13:08:47, tdresser wrote:
> Can you create a new bug for this change? It's pretty unrelated to the
> InputDevice work.

Or no bug at all is also fine.

> LGTM with nits.
> 
> https://codereview.chromium.org/1148813007/diff/60001/Source/core/core.gypi
> File Source/core/core.gypi (left):
> 
>
https://codereview.chromium.org/1148813007/diff/60001/Source/core/core.gypi#o...
> Source/core/core.gypi:288: 'inspector/JavaScriptCallFrame.idl',
> Why this change?
> 
>
https://codereview.chromium.org/1148813007/diff/60001/Source/web/tests/WebInp...
> File Source/web/tests/WebInputEventConversionTest.cpp (right):
> 
>
https://codereview.chromium.org/1148813007/diff/60001/Source/web/tests/WebInp...
> Source/web/tests/WebInputEventConversionTest.cpp:45: #include
> "core/input/InputDevice.h"
> I don't think these changes belong as part of this patch.

core/ rubber-stamp LGTM (modulo Tim's nits of course)

[lanwei, 2015-06-04 17:46:08]

lanwei@chromium.org changed reviewers:
+ thakis@chromium.org

[lanwei, 2015-06-04 17:46:09]

thakis@chromium.org: Please review changes in 

Source/web,

thanks.

[lanwei, 2015-06-04 17:53:05]

lanwei@chromium.org changed reviewers:
- thakis@chromium.org

[lanwei, 2015-06-04 17:56:20]

lanwei@chromium.org changed reviewers:
+ bokan@chromium.org

[lanwei, 2015-06-04 17:56:21]

bokan@chromium.org: Please review changes in 

Source/web/

Thank you.

[bokan, 2015-06-04 17:57:49]

rs lgtm!

[Nico, 2015-06-04 18:19:11]

On 2015/06/04 17:46:09, lanwei wrote:
> mailto:thakis@chromium.org: Please review changes in 
> 
> Source/web,
> 
> thanks.

Looks like someone else did that already. (Why ask two different people for
review 10 minutes apart?)

[lanwei, 2015-06-04 18:23:11]

On 2015/06/04 18:19:11, Nico wrote:
> On 2015/06/04 17:46:09, lanwei wrote:
> > mailto:thakis@chromium.org: Please review changes in 
> > 
> > Source/web,
> > 
> > thanks.
> 
> Looks like someone else did that already. (Why ask two different people for
> review 10 minutes apart?)

I am sorry, I found someone in my team to review this, because there are more
related CLs coming, I feel it is better to have the same person review all of
these.
Thanks for taking a look at this, and sorry for this.

[lanwei, 2015-06-05 17:21:21]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2015-06-05 17:21:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1148813007/#ps80001
(title: "Remove unnecessary file")

[commit-bot: I haz the power, 2015-06-05 17:21:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148813007/80001

[commit-bot: I haz the power, 2015-06-05 17:27:34]

Committed patchset #2 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196589

[Miyoung Shin(g), 2015-06-08 05:16:15]

Hi, I'm trying to move out the Selection codes from EventHandler at
http://crrev.com/1113323002/.
But my patch is a conflict with this patch.
So, I have a few of question.

1. Build 
IIUC, currently we compile core/page/EventHandler.cpp, but we see the header in
core/input/EventHandler.h.
When will you move core/page/EventHandler.cpp to core/input/EventHandler.cpp in
Source/core/core.gypi ?

2. Remove
When will you remove core/page/EventHandler.cpp in repo ?
I'm not sure that I should change both of core/page/EventHandler.cpp and
core/input/EventHandler.cpp.

It would be great if I get your plan.

[Miyoung Shin(g), 2015-06-08 07:04:33]

On 2015/06/08 05:16:15, Miyoung Shin(g) wrote:
> Hi, I'm trying to move out the Selection codes from EventHandler at
> http://crrev.com/1113323002/.
> But my patch is a conflict with this patch.
> So, I have a few of question.
> 
> 1. Build 
> IIUC, currently we compile core/page/EventHandler.cpp, but we see the header
in
> core/input/EventHandler.h.
> When will you move core/page/EventHandler.cpp to core/input/EventHandler.cpp
in
> Source/core/core.gypi ?
> 
> 2. Remove
> When will you remove core/page/EventHandler.cpp in repo ?
> I'm not sure that I should change both of core/page/EventHandler.cpp and
> core/input/EventHandler.cpp.
> 
> It would be great if I get your plan.

I saw to get rid of this at http://crrev.com/1153723010/. Now It's clear.

[Rick Byers, 2015-06-08 13:59:18]

On 2015/06/08 05:16:15, Miyoung Shin(g) wrote:
> Hi, I'm trying to move out the Selection codes from EventHandler at
> http://crrev.com/1113323002/.
> But my patch is a conflict with this patch.
> So, I have a few of question.
> 
> 1. Build 
> IIUC, currently we compile core/page/EventHandler.cpp, but we see the header
in
> core/input/EventHandler.h.
> When will you move core/page/EventHandler.cpp to core/input/EventHandler.cpp
in
> Source/core/core.gypi ?
> 
> 2. Remove
> When will you remove core/page/EventHandler.cpp in repo ?
> I'm not sure that I should change both of core/page/EventHandler.cpp and
> core/input/EventHandler.cpp.
> 
> It would be great if I get your plan.

Darn, I totally missed these issues in review - I'm sorry!

[lanwei, 2015-06-08 15:25:37]

On 2015/06/08 13:59:18, Rick Byers wrote:
> On 2015/06/08 05:16:15, Miyoung Shin(g) wrote:
> > Hi, I'm trying to move out the Selection codes from EventHandler at
> > http://crrev.com/1113323002/.
> > But my patch is a conflict with this patch.
> > So, I have a few of question.
> > 
> > 1. Build 
> > IIUC, currently we compile core/page/EventHandler.cpp, but we see the header
> in
> > core/input/EventHandler.h.
> > When will you move core/page/EventHandler.cpp to core/input/EventHandler.cpp
> in
> > Source/core/core.gypi ?
> > 
> > 2. Remove
> > When will you remove core/page/EventHandler.cpp in repo ?
> > I'm not sure that I should change both of core/page/EventHandler.cpp and
> > core/input/EventHandler.cpp.
> > 
> > It would be great if I get your plan.
> 
> Darn, I totally missed these issues in review - I'm sorry!

I am very sorry about this, I did delete and change the core file, but I do not
know why it was lost when I rebased or uploaded, I will double check once I
upload all files.