Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1148813005: Fixing crash in GPU memory dump. Will investigate more correct solution in a separate CL. (Closed)

Created:
5 years, 6 months ago by cblume
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing crash in GPU memory dump. Will investigate more correct solution in a separate CL. BUG=483467 TBR=ccameron@chromium.org,primiano@chromium.org Committed: https://crrev.com/9e9f4eb637c9b2e80041a1221ef024712c749e69 Cr-Commit-Position: refs/heads/master@{#333034}

Patch Set 1 #

Patch Set 2 : Reverted Issue 1131073003, which broke memory dumps on debug builds. #

Patch Set 3 : Did not revert correctly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M content/common/gpu/gpu_channel_manager.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 1 2 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
cblume
5 years, 6 months ago (2015-06-03 17:58:30 UTC) #2
ccameron
Please revert the offending CL instead. Leaving commented-out lines (which don't have correct style) checked-in ...
5 years, 6 months ago (2015-06-03 18:56:11 UTC) #3
Primiano Tucci (use gerrit)
On 2015/06/03 18:56:11, ccameron wrote: > Please revert the offending CL instead. Leaving commented-out lines ...
5 years, 6 months ago (2015-06-03 19:37:44 UTC) #4
cblume
A proper revert this time.
5 years, 6 months ago (2015-06-03 21:29:37 UTC) #5
ccameron
lg once the resolve issues are fixed.
5 years, 6 months ago (2015-06-03 21:44:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148813005/40001
5 years, 6 months ago (2015-06-03 23:21:12 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-03 23:21:16 UTC) #10
ccameron
lgtm
5 years, 6 months ago (2015-06-03 23:25:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148813005/40001
5 years, 6 months ago (2015-06-05 10:39:01 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-05 12:00:21 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:01:16 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9e9f4eb637c9b2e80041a1221ef024712c749e69
Cr-Commit-Position: refs/heads/master@{#333034}

Powered by Google App Engine
This is Rietveld 408576698