chrome/app/nibs/PRESUBMIT.py - Issue 11488009: Add content settings page action for Pepper broker authorization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/nibs/PRESUBMIT.py

Issue 11488009: Add content settings page action for Pepper broker authorization. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/nibs/PRESUBMIT.py

diff --git a/chrome/app/nibs/PRESUBMIT.py b/chrome/app/nibs/PRESUBMIT.py

index ffb09d0d044dadf8ee19a13616ea75d7c6451922..a04ecc9e15711b89b444b273597eb827c16879bf 100644

--- a/chrome/app/nibs/PRESUBMIT.py

+++ b/chrome/app/nibs/PRESUBMIT.py

@@ -33,6 +33,9 @@ def _CheckXIBSystemAndXcodeVersions(input_api, output_api, error_type):

incorrect_ib_versions = []

for xib in affected_xibs:

+ if len(xib.NewContents()) == 0:

+ continue

system_version = None

ib_version = None

for line in xib.NewContents():