Check for embedded PAC scripts when migrating proxy pref for DRP.

Check for embedded PAC scripts when migrating proxy pref for DRP.

In M35 and earlier, the Data Reduction Proxy was enabled by setting the
proxy pref to an embedded PAC script. As of M41, Chrome would no longer
clear this embedded DRP PAC script, possibly causing the DRP to be used
when it shouldn't be if a client upgrades directly from M35- to M41+.

This change causes Chrome to clear the proxy pref if it represents an
embedded PAC script that contains the string ".googlezip.net:".

BUG=476610
Committed: https://crrev.com/3391c30e356838d069f9a344e439314d24dba0c6
Cr-Commit-Position: refs/heads/master@{#333319}

[sclittle, 2015-06-06 05:02:47]

sclittle@chromium.org changed reviewers:
+ asvitkine@chromium.org, bengr@chromium.org

[sclittle, 2015-06-06 05:02:47]

bengr: *
asvitkine: histograms.xml

Thanks in advance!

[bengr, 2015-06-08 18:26:33]

https://codereview.chromium.org/1148793008/diff/1/chrome/browser/net/spdyprox...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
(right):

https://codereview.chromium.org/1148793008/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:65: bool
GetEmbeddedPacScript(const std::string& pac_url, std::string* pac_script) {
Can the pac_script be const? Can it ever be null?

https://codereview.chromium.org/1148793008/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:69:
base::Base64Decode(pac_url.substr(kPacURLPrefix.size()), pac_script);
Will the pac always be base64?

[sclittle, 2015-06-08 18:45:52]

Patchset #2 (id:20001) has been deleted

[sclittle, 2015-06-08 18:47:45]

https://codereview.chromium.org/1148793008/diff/1/chrome/browser/net/spdyprox...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
(right):

https://codereview.chromium.org/1148793008/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:65: bool
GetEmbeddedPacScript(const std::string& pac_url, std::string* pac_script) {
On 2015/06/08 18:26:33, bengr wrote:
> Can the pac_script be const? Can it ever be null?

I've updated the comment to clarify that pac_script can't be null, and that the
extracted PAC script is stored in it.

https://codereview.chromium.org/1148793008/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc:69:
base::Base64Decode(pac_url.substr(kPacURLPrefix.size()), pac_script);
On 2015/06/08 18:26:33, bengr wrote:
> Will the pac always be base64?

Yes, according to the way that the DRP was enabled in M35-. Base64Decode will
return false if decoding is unsuccessful.

[sclittle, 2015-06-08 19:02:03]

sclittle@chromium.org changed reviewers:
- asvitkine@chromium.org

[sclittle, 2015-06-08 19:02:04]

-asvitkine as a reviewer, since this has to get in ASAP

I'll make the histograms.xml change at a later date, I've removed it from this
CL.

[bengr, 2015-06-08 19:07:51]

lgtm

[sclittle, 2015-06-08 19:08:25]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2015-06-08 19:10:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148793008/60001

[commit-bot: I haz the power, 2015-06-08 19:42:47]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-06-08 19:43:36]

Patchset 3 (id:??) landed as
https://crrev.com/3391c30e356838d069f9a344e439314d24dba0c6
Cr-Commit-Position: refs/heads/master@{#333319}