Issue 1148793005: Prepare StockList for use in stocks2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148793005: Prepare StockList for use in stocks2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie, eseidel

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Prepare StockList for use in stocks2 This CL does a bunch of ground work for getting StockList ready for use in stocks2. It's still not quite working because of an interaction with Scaffold that we don't fully understand. R=eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2f79234d294bcffc66b1de67fb9b8260cd0c603c

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -49 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/stocks2/lib/stock_data.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_list.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/stocks2/lib/stock_row.dart	View	1 chunk	+56 lines, -45 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 6 months ago (2015-06-04 22:10:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f79234d294bcffc66b1de67fb9b8260cd0c603c (presubmit successful).