chrome/browser/ui/content_settings/content_setting_bubble_model.cc - Issue 1148773005: Add a RAPPOR metric to track where users click to allow mixed scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 1148773005: Add a RAPPOR metric to track where users click to allow mixed scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move mixed script shield RAPPOR stats into a new RecordMixedScriptActionWithRAPPOR() function. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/chrome_content_settings_utils.cc ('K') | « chrome/browser/content_settings/tab_specific_content_settings.cc ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

index bdc7df799563be57ae400c71306f41395bd38395..9699279e84c8b2bccecedad50aab919008bd69a1 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

@@ -996,13 +996,15 @@ ContentSettingMixedScriptBubbleModel::ContentSettingMixedScriptBubbleModel(

}

void ContentSettingMixedScriptBubbleModel::OnCustomLinkClicked() {

- content_settings::RecordMixedScriptAction(

- content_settings::MIXED_SCRIPT_ACTION_CLICKED_ALLOW);

DCHECK(web_contents());

web_contents()->SendToAllFrames(

new ChromeViewMsg_SetAllowRunningInsecureContent(MSG_ROUTING_NONE, true));

web_contents()->GetMainFrame()->Send(new ChromeViewMsg_ReloadFrame(

web_contents()->GetMainFrame()->GetRoutingID()));

+ content_settings::RecordMixedScriptActionWithRAPPOR(

+ content_settings::MIXED_SCRIPT_ACTION_CLICKED_ALLOW,

+ web_contents()->GetLastCommittedURL());

}

ContentSettingRPHBubbleModel::ContentSettingRPHBubbleModel(