Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4541)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 1148773005: Add a RAPPOR metric to track where users click to allow mixed scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forward-declare GURL. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/content_settings/tab_specific_content_settings.cc ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/content_settings/content_setting_bubble_model.cc
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
index b0acf9a699d62e14e6d17219dc6e563d13aea9be..1e06b979e3371c802d94095cb50122cff7a5176c 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
@@ -983,13 +983,17 @@ ContentSettingMixedScriptBubbleModel::ContentSettingMixedScriptBubbleModel(
}
void ContentSettingMixedScriptBubbleModel::OnCustomLinkClicked() {
- content_settings::RecordMixedScriptAction(
- content_settings::MIXED_SCRIPT_ACTION_CLICKED_ALLOW);
DCHECK(web_contents());
web_contents()->SendToAllFrames(
new ChromeViewMsg_SetAllowRunningInsecureContent(MSG_ROUTING_NONE, true));
web_contents()->GetMainFrame()->Send(new ChromeViewMsg_ReloadFrame(
web_contents()->GetMainFrame()->GetRoutingID()));
+
+ content_settings::RecordMixedScriptAction(
+ content_settings::MIXED_SCRIPT_ACTION_CLICKED_ALLOW);
+ content_settings::RecordMixedScriptActionWithRAPPOR(
+ content_settings::MIXED_SCRIPT_ACTION_CLICKED_ALLOW,
+ web_contents()->GetLastCommittedURL());
}
ContentSettingRPHBubbleModel::ContentSettingRPHBubbleModel(
« no previous file with comments | « chrome/browser/content_settings/tab_specific_content_settings.cc ('k') | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698