Invalidate SVG filter display items on subtree modification

Source/core/layout/svg/LayoutSVGResourceFilter.cpp

Index: Source/core/layout/svg/LayoutSVGResourceFilter.cpp
diff --git a/Source/core/layout/svg/LayoutSVGResourceFilter.cpp b/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
index db677188d670e44d066b1a2f60492b42b1820ce7..0e06038b557384fc3644c6dd38f1c5969209b991 100644
--- a/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
+++ b/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
@@ -79,6 +79,10 @@ bool LayoutSVGResourceFilter::isChildAllowed(LayoutObject* child, const Computed
 
 void LayoutSVGResourceFilter::removeAllClientsFromCache(bool markForInvalidation)
 {
+    // LayoutSVGResourceFilter::removeClientFromCache will be called for
+    // all clients through markAllClientsForInvalidation so no explicit
+    // display item invalidation is needed here.
+
     disposeFilterMap();
     markAllClientsForInvalidation(markForInvalidation ? LayoutAndBoundariesInvalidation : ParentOnlyInvalidation);
 }
@@ -87,9 +91,14 @@ void LayoutSVGResourceFilter::removeClientFromCache(LayoutObject* client, bool m
 {
     ASSERT(client);
 
-    m_filter.remove(client);
+    InvalidationMode invalidation = markForInvalidation ? BoundariesInvalidation : ParentOnlyInvalidation;
 
-    markClientForInvalidation(client, markForInvalidation ? BoundariesInvalidation : ParentOnlyInvalidation);
+    // If the filter has a cached subtree, invalidate the associated display item.
+    if (RuntimeEnabledFeatures::slimmingPaintEnabled() && markForInvalidation && m_filter.contains(client))
+        invalidation = PaintInvalidation;

[fs, 2015/05/20 09:29:38]

So this means that boundaries are not marked as dirty? Seems fair when the
filter wasn't mutated, but can we discern that case here?

[pdr., 2015/05/20 21:09:27]

Good catch (not sure why there weren't test failures). I've updated the patch so
the boundaries invalidation is preserved.

+
+    m_filter.remove(client);
+    markClientForInvalidation(client, invalidation);
 }
 
 PassRefPtrWillBeRawPtr<SVGFilterBuilder> LayoutSVGResourceFilter::buildPrimitives(SVGFilter* filter)