Issue 1148743002: Show the location bar in bookmark apps with security errors.

Issue 1148743002: Show the location bar in bookmark apps with security errors. (Closed)

Created:
5 years, 7 months ago by benwells

Modified:
5 years, 7 months ago

Reviewers:
felt

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Show the location bar in bookmark apps with security errors. For example, if the certificate is expired. BUG=442930 Committed: https://crrev.com/4d146d0bb1a374d628f3d67885bd02d96fcbb42a Cr-Commit-Position: refs/heads/master@{#330833}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -2 lines)			Patch
M	chrome/browser/ssl/connection_security_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ssl/connection_security_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/extensions/bookmark_app_browser_controller.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148743002/1

5 years, 7 months ago (2015-05-20 21:45:59 UTC) #5

felt

Ben, you'll need to file a separate bug for this so that it can be ...

5 years, 7 months ago (2015-05-20 22:13:46 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 23:29:28 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4d146d0bb1a374d628f3d67885bd02d96fcbb42a
Cr-Commit-Position: refs/heads/master@{#330833}