Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2948)

Unified Diff: chrome/browser/ui/ash/cast_config_delegate_chromeos.cc

Issue 1148713004: Cast extension method stopCastMirroring was renamed to stopMirroring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/cast_config_delegate_chromeos.cc
diff --git a/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc b/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc
index 9873cf404c009dd69fa9d0d8da2cd80f6a693ae2..b2196e97705e01ef346d7214d2696d8168ced72f 100644
--- a/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc
+++ b/chrome/browser/ui/ash/cast_config_delegate_chromeos.cc
@@ -139,12 +139,13 @@ void CastConfigDelegateChromeos::CastToReceiver(
}
void CastConfigDelegateChromeos::StopCasting() {
- ExecuteJavaScript("backgroundSetup.stopCastMirroring('user-stop');");
+ ExecuteJavaScript("backgroundSetup.stopMirroring('user-stop')");
- // TODO(jdufault): Remove this after stopCastMirroring is properly exported.
- // The current beta/release versions of the cast extension do not export
- // stopCastMirroring, so we will also try to call the minified version.
- // See crbug.com/489929.
+ // TODO(jdufault): Remove this after the beta/release versions of the
+ // cast extension have been updated so that they properly export the
+ // stopMirroring function. For now, we try to invoke all of the other
+ // names that the function goes by. See crbug.com/489929.
+ ExecuteJavaScript("backgroundSetup.stopCastMirroring('user-stop');");
ExecuteJavaScript("backgroundSetup.Qu('user-stop');");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698