Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1148713002: [Cleanup] Eliminate a bit of console spam. (Closed)

Created:
5 years, 7 months ago by Ilya Sherman
Modified:
5 years, 7 months ago
Reviewers:
Tim Song
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Eliminate a bit of console spam. Stop calling BluetoothAdapter::IsDiscoverable() on non-ChromeOS platforms, as this method is only implemented on ChromeOS, and the feature code that was calling it currently only runs on ChromeOS. BUG=488263 TEST=none R=tengs@chromium.org Committed: https://crrev.com/d6c1d86967b07198a9c62cf32802ac6ed6e48e48 Cr-Commit-Position: refs/heads/master@{#330867}

Patch Set 1 #

Patch Set 2 : Sing a lullaby to soothe the Windows compiler's soul. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/signin/easy_unlock_service.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ilya Sherman
5 years, 7 months ago (2015-05-20 04:34:48 UTC) #1
Tim Song
lgtm
5 years, 7 months ago (2015-05-20 07:07:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148713002/1
5 years, 7 months ago (2015-05-20 07:16:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/85625)
5 years, 7 months ago (2015-05-20 07:46:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148713002/20001
5 years, 7 months ago (2015-05-20 23:15:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 01:20:06 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 01:20:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6c1d86967b07198a9c62cf32802ac6ed6e48e48
Cr-Commit-Position: refs/heads/master@{#330867}

Powered by Google App Engine
This is Rietveld 408576698