Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1148703002: Remove mojo::InterfaceImpl from extensions. (Closed)

Created:
5 years, 7 months ago by Sam McNally
Modified:
5 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mojo::InterfaceImpl from extensions. BUG=489751 Committed: https://crrev.com/ceff908a1afba3e54c7d6ec133654e5afb4007a6 Cr-Commit-Position: refs/heads/master@{#330699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -18 lines) Patch
M extensions/browser/api/mime_handler_private/mime_handler_private.h View 3 chunks +7 lines, -4 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/browser/mojo/keep_alive_impl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M extensions/browser/mojo/keep_alive_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M extensions/renderer/mojo/keep_alive_client_unittest.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
5 years, 7 months ago (2015-05-20 04:46:36 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 7 months ago (2015-05-20 04:51:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148703002/1
5 years, 7 months ago (2015-05-20 04:52:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 04:55:47 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 04:56:36 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ceff908a1afba3e54c7d6ec133654e5afb4007a6
Cr-Commit-Position: refs/heads/master@{#330699}

Powered by Google App Engine
This is Rietveld 408576698