Issue 1148653012: Fix a double download issue on desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148653012: Fix a double download issue on desktop (Closed)

Created:
5 years, 6 months ago by Yoav Weiss

Modified:
5 years, 6 months ago

Reviewers:
Mike West

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, Yoav Weiss

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix a double download issue on desktop While adding <meta viewport> support to the preloadScanner, in order to avoid double download issues, I failed to add such support only in cases where <meta viewport> is actually supported, resulting in double downloads in the opposite case. This CL fixes that bug. BUG=493110 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196061

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -1 line)			Patch
M	Source/core/html/parser/HTMLPreloadScanner.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/parser/HTMLPreloadScanner.cpp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/html/parser/HTMLPreloadScannerTest.cpp	View	3 chunks	+32 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Yoav Weiss

An embarrassing bug resulting in double downloads in M44 :/ Mike - can you take ...

5 years, 6 months ago (2015-05-28 12:29:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148653012/1

5 years, 6 months ago (2015-05-28 12:53:31 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-05-28 13:46:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196061

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages