Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: pylib/gyp/generator/msvs.py

Issue 1148653011: msvs: Make sure stdout/stderr from rule commands get logged (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import copy 5 import copy
6 import ntpath 6 import ntpath
7 import os 7 import os
8 import posixpath 8 import posixpath
9 import re 9 import re
10 import subprocess 10 import subprocess
(...skipping 2327 matching lines...) Expand 10 before | Expand all | Expand 10 after
2338 {'Condition': "'@(%s)' != '' and '%%(%s.ExcludedFromBuild)' != " 2338 {'Condition': "'@(%s)' != '' and '%%(%s.ExcludedFromBuild)' != "
2339 "'true'" % (rule.tlog, rule.tlog), 2339 "'true'" % (rule.tlog, rule.tlog),
2340 'File': '$(IntDir)$(ProjectName).read.1.tlog', 2340 'File': '$(IntDir)$(ProjectName).read.1.tlog',
2341 'Lines': "^%%(%s.Source);%%(%s.Inputs)" % (rule.tlog, rule.tlog) 2341 'Lines': "^%%(%s.Source);%%(%s.Inputs)" % (rule.tlog, rule.tlog)
2342 } 2342 }
2343 ] 2343 ]
2344 command_and_input_section = [ 2344 command_and_input_section = [
2345 rule_name, 2345 rule_name,
2346 {'Condition': "'@(%s)' != '' and '%%(%s.ExcludedFromBuild)' != " 2346 {'Condition': "'@(%s)' != '' and '%%(%s.ExcludedFromBuild)' != "
2347 "'true'" % (rule_name, rule_name), 2347 "'true'" % (rule_name, rule_name),
2348 'EchoOff': 'true',
2349 'StandardOutputImportance': 'High',
2350 'StandardErrorImportance': 'High',
2348 'CommandLineTemplate': '%%(%s.CommandLineTemplate)' % rule_name, 2351 'CommandLineTemplate': '%%(%s.CommandLineTemplate)' % rule_name,
2349 'AdditionalOptions': '%%(%s.AdditionalOptions)' % rule_name, 2352 'AdditionalOptions': '%%(%s.AdditionalOptions)' % rule_name,
2350 'Inputs': rule_inputs 2353 'Inputs': rule_inputs
2351 } 2354 }
2352 ] 2355 ]
2353 content.extend([ 2356 content.extend([
2354 ['Target', 2357 ['Target',
2355 {'Name': rule.target_name, 2358 {'Name': rule.target_name,
2356 'BeforeTargets': '$(%s)' % rule.before_targets, 2359 'BeforeTargets': '$(%s)' % rule.before_targets,
2357 'AfterTargets': '$(%s)' % rule.after_targets, 2360 'AfterTargets': '$(%s)' % rule.after_targets,
(...skipping 1070 matching lines...) Expand 10 before | Expand all | Expand 10 after
3428 action_spec.extend( 3431 action_spec.extend(
3429 # TODO(jeanluc) 'Document' for all or just if as_sources? 3432 # TODO(jeanluc) 'Document' for all or just if as_sources?
3430 [['FileType', 'Document'], 3433 [['FileType', 'Document'],
3431 ['Command', command], 3434 ['Command', command],
3432 ['Message', description], 3435 ['Message', description],
3433 ['Outputs', outputs] 3436 ['Outputs', outputs]
3434 ]) 3437 ])
3435 if additional_inputs: 3438 if additional_inputs:
3436 action_spec.append(['AdditionalInputs', additional_inputs]) 3439 action_spec.append(['AdditionalInputs', additional_inputs])
3437 actions_spec.append(action_spec) 3440 actions_spec.append(action_spec)
OLDNEW
« no previous file with comments | « no previous file | test/msvs/rules_stdout_stderr/dummy.bar » ('j') | test/msvs/rules_stdout_stderr/rule_stderr.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698