Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: Source/core/editing/MarkupFormatter.h

Issue 1148633010: Refactoring: Separate MarkupAccumulator into MarkupFormatter and MarkupAccumulator (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/MarkupAccumulator.cpp ('k') | Source/core/editing/MarkupFormatter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/MarkupFormatter.h
diff --git a/Source/core/editing/MarkupAccumulator.h b/Source/core/editing/MarkupFormatter.h
similarity index 78%
copy from Source/core/editing/MarkupAccumulator.h
copy to Source/core/editing/MarkupFormatter.h
index 11630f843065f146eb2b0c6f16d5c128348894b5..a488674e20e30b1ccbb506e7a2b35a385de750f8 100644
--- a/Source/core/editing/MarkupAccumulator.h
+++ b/Source/core/editing/MarkupFormatter.h
@@ -23,8 +23,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef MarkupAccumulator_h
-#define MarkupAccumulator_h
+#ifndef MarkupFormatter_h
+#define MarkupFormatter_h
#include "core/editing/EditingStrategy.h"
#include "core/editing/markup.h"
@@ -62,39 +62,28 @@ enum class SerializationType {
ForcedXML
};
-class MarkupAccumulator {
- WTF_MAKE_NONCOPYABLE(MarkupAccumulator);
+class MarkupFormatter final {
+ WTF_MAKE_NONCOPYABLE(MarkupFormatter);
STACK_ALLOCATED();
public:
static void appendComment(StringBuilder&, const String&);
static void appendCharactersReplacingEntities(StringBuilder&, const String&, unsigned, unsigned, EntityMask);
static size_t totalLength(const Vector<String>&);
- MarkupAccumulator(EAbsoluteURLs, SerializationType = SerializationType::AsOwnerDocument);
- virtual ~MarkupAccumulator();
+ MarkupFormatter(EAbsoluteURLs, SerializationType = SerializationType::AsOwnerDocument);
+ ~MarkupFormatter();
- void appendString(const String&);
- virtual void appendStartTag(Node&, Namespaces* = nullptr);
- virtual void appendEndTag(const Element&);
- void appendStartMarkup(StringBuilder&, Node&, Namespaces*);
void appendEndMarkup(StringBuilder&, const Element&);
- size_t length() const { return m_markup.length(); }
- void concatenateMarkup(StringBuilder&) const;
-
bool serializeAsHTMLDocument(const Node&) const;
- String toString() { return m_markup.toString(); }
void appendAttributeValue(StringBuilder&, const String&, bool);
- virtual void appendCustomAttributes(StringBuilder&, const Element&, Namespaces*);
void appendNamespace(StringBuilder&, const AtomicString& prefix, const AtomicString& namespaceURI, Namespaces&);
- virtual void appendText(StringBuilder&, Text&);
+ void appendText(StringBuilder&, Text&);
void appendXMLDeclaration(StringBuilder&, const Document&);
void appendDocumentType(StringBuilder&, const DocumentType&);
void appendProcessingInstruction(StringBuilder&, const String& target, const String& data);
- virtual bool shouldIgnoreAttribute(const Attribute&);
- virtual void appendElement(StringBuilder&, Element&, Namespaces*);
void appendOpenTag(StringBuilder&, const Element&, Namespaces*);
void appendCloseTag(StringBuilder&, const Element&);
void appendAttribute(StringBuilder&, const Element&, const Attribute&, Namespaces*);
@@ -109,16 +98,10 @@ private:
String resolveURLIfNeeded(const Element&, const String&) const;
void appendQuotedURLAttributeValue(StringBuilder&, const Element&, const Attribute&);
- StringBuilder m_markup;
const EAbsoluteURLs m_resolveURLsMethod;
SerializationType m_serializationType;
};
-template<typename Strategy>
-String serializeNodes(MarkupAccumulator&, Node&, EChildrenOnly);
-
-extern template String serializeNodes<EditingStrategy>(MarkupAccumulator&, Node&, EChildrenOnly);
-
}
#endif
« no previous file with comments | « Source/core/editing/MarkupAccumulator.cpp ('k') | Source/core/editing/MarkupFormatter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698