Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1148633010: Refactoring: Separate MarkupAccumulator into MarkupFormatter and MarkupAccumulator (Closed)

Created:
4 years, 11 months ago by hajimehoshi
Modified:
4 years, 11 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Separate MarkupAccumulator into MarkupFormatter and MarkupAccumulator Now MarkupAccumulator has two functions; one is to format a DOM node to a string and the other is to accumulate the result of formatting. This CL separates MarkupAccumulator into MarkupFormatter and MarkupAccumulator for respective functions. MarkupFormatter only formats nodes to texts, and (new) MarkupAccumulator uses MarkupFormatter and accumulates the result. Now most of MarkupAccumulator functions delegates their work to MarkupFormatter just by calling the samely named functions. I plan to refactor those classes further more by reducing redundant function calls. This patch is result of collaboration work with yosin@chromium.org for selection of web components. We've already prepared the new node-traversal usages at crrev.com/1134473004. StyledMarkupAccumulator is now using MarkupAccumulator, and I plan to change this to use MarkupFormatter. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196448

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -512 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.h View 3 chunks +2 lines, -32 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 6 chunks +18 lines, -312 lines 0 comments Download
A + Source/core/editing/MarkupFormatter.h View 3 chunks +7 lines, -24 lines 0 comments Download
A + Source/core/editing/MarkupFormatter.cpp View 21 chunks +24 lines, -138 lines 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
hajimehoshi
PTAL
4 years, 11 months ago (2015-06-03 10:58:10 UTC) #2
tkent
lgtm
4 years, 11 months ago (2015-06-04 00:06:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148633010/1
4 years, 11 months ago (2015-06-04 00:07:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46437) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
4 years, 11 months ago (2015-06-04 00:10:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148633010/20001
4 years, 11 months ago (2015-06-04 01:42:26 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 03:04:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196448

Powered by Google App Engine
This is Rietveld 408576698