Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: content/public/browser/background_tracing_manager.h

Issue 1148633007: Hooked the trace event argument whitelist up to the background_trace_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/background_tracing_manager.h
diff --git a/content/public/browser/background_tracing_manager.h b/content/public/browser/background_tracing_manager.h
index d5e0900f161194badf775087ec0d3bc225de9f24..dd3e3d0a3f1ef81453d77697b3eddc5128b4e5e1 100644
--- a/content/public/browser/background_tracing_manager.h
+++ b/content/public/browser/background_tracing_manager.h
@@ -39,8 +39,8 @@ class BackgroundTracingManager {
// );
// }
//
- typedef base::Callback<void(const base::RefCountedString*, base::Closure)>
- ReceiveCallback;
+ typedef base::Callback<void(const scoped_refptr<base::RefCountedString>&,
+ base::Closure)> ReceiveCallback;
// Set the triggering rules for when to start recording.
//
@@ -59,6 +59,7 @@ class BackgroundTracingManager {
// the manager is idle and a config can be set again.
virtual bool SetActiveScenario(scoped_ptr<BackgroundTracingConfig> config,
const ReceiveCallback& receive_callback,
+ const base::Closure& enabled_callback,
dsinclair 2015/06/01 15:09:37 What is this for? I see it pass around all over th
oystein (OOO til 10th of July) 2015/06/01 18:23:39 It's used in the BackgroundTracingManagerBrowserTe
dsinclair 2015/06/01 18:50:05 If it's only for testing, it's too bad we have to
oystein (OOO til 10th of July) 2015/06/01 20:46:20 Done.
bool requires_anonymized_data) = 0;
// Notifies the caller when the manager is idle (not recording or uploading),

Powered by Google App Engine
This is Rietveld 408576698