content/public/browser/background_tracing_manager.h - Issue 1148633007: Hooked the trace event argument whitelist up to the background_trace_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/background_tracing_manager.h

Issue 1148633007: Hooked the trace event argument whitelist up to the background_trace_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/background_tracing_config.h ('K') | « content/public/browser/background_tracing_config.cc ('k') | content/public/browser/tracing_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/background_tracing_manager.h

diff --git a/content/public/browser/background_tracing_manager.h b/content/public/browser/background_tracing_manager.h

index d5e0900f161194badf775087ec0d3bc225de9f24..dd3e3d0a3f1ef81453d77697b3eddc5128b4e5e1 100644

--- a/content/public/browser/background_tracing_manager.h

+++ b/content/public/browser/background_tracing_manager.h

@@ -39,8 +39,8 @@ class BackgroundTracingManager {

// );

// }

- typedef base::Callback<void(const base::RefCountedString*, base::Closure)>

- ReceiveCallback;

+ typedef base::Callback<void(const scoped_refptr<base::RefCountedString>&,

shatch 2015/05/22 22:21:37 Intentional change?

+ base::Closure)> ReceiveCallback;

// Set the triggering rules for when to start recording.

@@ -59,6 +59,7 @@ class BackgroundTracingManager {

// the manager is idle and a config can be set again.

virtual bool SetActiveScenario(scoped_ptr<BackgroundTracingConfig> config,

const ReceiveCallback& receive_callback,

+ const base::Closure& enabled_callback,

bool requires_anonymized_data) = 0;

// Notifies the caller when the manager is idle (not recording or uploading),