Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1148613004: Disable app shutdown logic for now while I fix the network_service apptests. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable app shutdown logic for now while I fix the network_service apptests. BUG=484234 TBR=msw@chromium.org Committed: https://crrev.com/e981c21c49927bfff7a84651717682f4fad75fd7 Cr-Commit-Position: refs/heads/master@{#330606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M mojo/application/app_lifetime_helper.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jam
5 years, 7 months ago (2015-05-19 20:59:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148613004/1
5 years, 7 months ago (2015-05-19 21:00:58 UTC) #3
msw
lgtm, sorry :(
5 years, 7 months ago (2015-05-19 21:02:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 21:11:58 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:12:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e981c21c49927bfff7a84651717682f4fad75fd7
Cr-Commit-Position: refs/heads/master@{#330606}

Powered by Google App Engine
This is Rietveld 408576698