Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1148613002: [Sync] Remove periodic sync for Chrome for Android (Closed)

Created:
5 years, 7 months ago by maxbogue
Modified:
5 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove periodic sync for Chrome for Android updateAccount() is always called on startup with the signed in account, so the removePeriodicSync() call will be hit even for already signed in users when the app restarts. BUG=480688 Committed: https://crrev.com/20989a55f294c1b1643cbc2b80bf083de1dd7e36 Cr-Commit-Position: refs/heads/master@{#330588}

Patch Set 1 #

Patch Set 2 : Self-review. #

Messages

Total messages: 9 (2 generated)
maxbogue
Hey Tommy, PTAL!
5 years, 7 months ago (2015-05-19 18:38:27 UTC) #2
nyquist
lgtm
5 years, 7 months ago (2015-05-19 18:53:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148613002/20001
5 years, 7 months ago (2015-05-19 19:57:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 20:02:58 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/20989a55f294c1b1643cbc2b80bf083de1dd7e36 Cr-Commit-Position: refs/heads/master@{#330588}
5 years, 7 months ago (2015-05-19 20:03:46 UTC) #7
sgurun-gerrit only
On 2015/05/19 20:03:46, I haz the power (commit-bot) wrote: > Patchset 2 (id:??) landed as ...
5 years, 7 months ago (2015-05-19 20:19:39 UTC) #8
sgurun-gerrit only
5 years, 7 months ago (2015-05-19 20:21:07 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1135113006/ by sgurun@chromium.org.

The reason for reverting is: seems to break the build
https://build.chromium.org/p/chromium/builders/Android/builds/40042.

Powered by Google App Engine
This is Rietveld 408576698