Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 1148603003: Remove X-Chrome-Exponential-Throttling header (Closed)

Created:
5 years, 7 months ago by xunjieli
Modified:
5 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove X-Chrome-Exponential-Throttling header This CL removes X-Chrome-Exponential-Throttling header support from net/ . BUG=352259 Committed: https://crrev.com/041e939081191e9cdf29bbce2964c54add9de771 Cr-Commit-Position: refs/heads/master@{#330619}

Patch Set 1 #

Patch Set 2 : Update manager #

Patch Set 3 : Fix test #

Total comments: 4

Patch Set 4 : Address comments #

Total comments: 4

Patch Set 5 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -304 lines) Patch
M net/net.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M net/url_request/url_request_throttler_entry.h View 1 2 3 3 chunks +3 lines, -17 lines 0 comments Download
M net/url_request/url_request_throttler_entry.cc View 1 2 3 6 chunks +6 lines, -33 lines 0 comments Download
M net/url_request/url_request_throttler_entry_interface.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
D net/url_request/url_request_throttler_header_adapter.h View 1 chunk +0 lines, -35 lines 0 comments Download
D net/url_request/url_request_throttler_header_adapter.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D net/url_request/url_request_throttler_header_interface.h View 1 chunk +0 lines, -28 lines 0 comments Download
M net/url_request/url_request_throttler_manager.h View 1 3 chunks +0 lines, -12 lines 0 comments Download
M net/url_request/url_request_throttler_manager.cc View 1 3 chunks +3 lines, -22 lines 0 comments Download
M net/url_request/url_request_throttler_simulation_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request_throttler_test_support.h View 2 chunks +0 lines, -30 lines 0 comments Download
M net/url_request/url_request_throttler_test_support.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M net/url_request/url_request_throttler_unittest.cc View 1 2 3 4 8 chunks +25 lines, -52 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
xunjieli
5 years, 7 months ago (2015-05-19 19:05:45 UTC) #2
mmenke
https://codereview.chromium.org/1148603003/diff/30001/net/url_request/url_request_throttler_entry.cc File net/url_request/url_request_throttler_entry.cc (right): https://codereview.chromium.org/1148603003/diff/30001/net/url_request/url_request_throttler_entry.cc#newcode220 net/url_request/url_request_throttler_entry.cc:220: void URLRequestThrottlerEntry::UpdateWithResponse(const std::string& host, This method no longer needs ...
5 years, 7 months ago (2015-05-19 19:18:37 UTC) #3
xunjieli
Thanks for the review! PTAL. https://codereview.chromium.org/1148603003/diff/30001/net/url_request/url_request_throttler_entry.cc File net/url_request/url_request_throttler_entry.cc (right): https://codereview.chromium.org/1148603003/diff/30001/net/url_request/url_request_throttler_entry.cc#newcode220 net/url_request/url_request_throttler_entry.cc:220: void URLRequestThrottlerEntry::UpdateWithResponse(const std::string& host, ...
5 years, 7 months ago (2015-05-19 20:06:44 UTC) #4
mmenke
LGTM https://codereview.chromium.org/1148603003/diff/50001/net/url_request/url_request_throttler_unittest.cc File net/url_request/url_request_throttler_unittest.cc (right): https://codereview.chromium.org/1148603003/diff/50001/net/url_request/url_request_throttler_unittest.cc#newcode454 net/url_request/url_request_throttler_unittest.cc:454: // Host doesn't really matter in this scenario ...
5 years, 7 months ago (2015-05-19 20:31:24 UTC) #5
xunjieli
Thanks! https://codereview.chromium.org/1148603003/diff/50001/net/url_request/url_request_throttler_unittest.cc File net/url_request/url_request_throttler_unittest.cc (right): https://codereview.chromium.org/1148603003/diff/50001/net/url_request/url_request_throttler_unittest.cc#newcode454 net/url_request/url_request_throttler_unittest.cc:454: // Host doesn't really matter in this scenario ...
5 years, 7 months ago (2015-05-19 20:54:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148603003/70001
5 years, 7 months ago (2015-05-19 20:55:23 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 7 months ago (2015-05-19 21:51:46 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:52:46 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/041e939081191e9cdf29bbce2964c54add9de771
Cr-Commit-Position: refs/heads/master@{#330619}

Powered by Google App Engine
This is Rietveld 408576698