Source/core/page/ChromeClient.h - Issue 1148603002: Anchor element's referrer attribute implementation for Referrer Policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/ChromeClient.h

Issue 1148603002: Anchor element's referrer attribute implementation for Referrer Policy Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fails for right-click opening (new window/tab, etc.) Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/ChromeClient.h

diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h

index a45c64247e96e1fd0026834ead3859bcc54222ab..9cda7e746675a3ba51834b675821d189d916e037 100644

--- a/Source/core/page/ChromeClient.h

+++ b/Source/core/page/ChromeClient.h

@@ -95,7 +95,7 @@ public:

// created Page has its show method called.

// The FrameLoadRequest parameter is only for ChromeClient to check if the

// request could be fulfilled. The ChromeClient should not load the request.

- virtual Page* createWindow(LocalFrame*, const FrameLoadRequest&, const WindowFeatures&, NavigationPolicy, ShouldSendReferrer) = 0;

+ virtual Page* createWindow(LocalFrame*, const FrameLoadRequest&, const WindowFeatures&, NavigationPolicy, ReferrerPolicy) = 0;

virtual void show(NavigationPolicy) = 0;

virtual void setToolbarsVisible(bool) = 0;

« Source/core/loader/FrameLoader.cpp ('K') | « Source/core/loader/FrameLoader.cpp ('k') | Source/core/page/CreateWindow.h » ('j') | Source/core/page/CreateWindow.cpp » ('J')