Simplify GetProperty helpers to ease element support

Simplify GetProperty helpers to ease element support

BUG=v8:4137
LOG=n

Committed: https://crrev.com/c2670d6187dc0dc56b3326064673eb7b72047c0a
Cr-Commit-Position: refs/heads/master@{#28556}

[Toon Verwaest, 2015-05-19 16:16:10]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2015-05-19 16:16:10]

PTAL

[Jakob Kummerow, 2015-05-20 09:06:50]

LGTM with nits.

https://codereview.chromium.org/1148583002/diff/1/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/1148583002/diff/1/src/lookup.cc#newcode358
src/lookup.cc:358: DCHECK(ExoticIndexState::kNotExotic != exotic_index_state_);
nit: the condition reads more naturally if you swap it (variable != kConstant).

https://codereview.chromium.org/1148583002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1148583002/diff/1/src/objects.cc#newcode315
src/objects.cc:315: THROW_NEW_ERROR(it->isolate(),
nit: consider "Isolate* isolate = it->isolate();" at the top of the function to
avoid a bunch of useless noise here and below.

[Toon Verwaest, 2015-05-21 13:28:45]

Addressed comments

[Toon Verwaest, 2015-05-21 13:32:01]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-05-21 13:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1148583002/#ps40001
(title: "More comments")

[commit-bot: I haz the power, 2015-05-21 13:32:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148583002/40001

[commit-bot: I haz the power, 2015-05-21 14:35:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-21 14:35:09]

Patchset 3 (id:??) landed as
https://crrev.com/c2670d6187dc0dc56b3326064673eb7b72047c0a
Cr-Commit-Position: refs/heads/master@{#28556}