[iOS] Upstream SyncSetupService (and mock)

[iOS] Upstream SyncSetupService (and mock)

SyncSetupService allows configuring sync. It handles enabling and disabling it,
as well as choosing datatypes. Most actions are delayed until a commit is done,
to allow the complex sync setup flow on iOS.

BUG=429756
Committed: https://crrev.com/5548199bedbf5452f0655aa236bebed3726ea1f2
Cr-Commit-Position: refs/heads/master@{#330736}

[sdefresne, 2015-05-19 16:01:35]

sdefresne@chromium.org changed reviewers:
+ atwilson@chromium.org, noyau@chromium.org, rogerta@chromium.org

[sdefresne, 2015-05-19 16:01:36]

noyau: please review (this is upstreaming code)

atwilson: OWNERS approval required for new DEPS on //sync
rogerta: OWNERS approval required for new DEPS on //google_api

** Presubmit Messages **
Missing LGTM from OWNERS of dependencies added to DEPS:
    '+google_apis',
    '+sync',

[Roger Tawa OOO till Jul 10th, 2015-05-19 19:29:32]

lgtm google_apis deps

[noyau (Ping after 24h), 2015-05-19 19:45:01]

This class is not tested, and the presence of a mock seems to indicate that it
is not even indirectly tested by something else. So it probably needs some
unittest coverage.

https://codereview.chromium.org/1148573002/diff/1/ios/chrome/browser/sync/syn...
File ios/chrome/browser/sync/sync_setup_service.cc (right):

https://codereview.chromium.org/1148573002/diff/1/ios/chrome/browser/sync/syn...
ios/chrome/browser/sync/sync_setup_service.cc:20: //
|SyncSetupService::SyncableDatatype|.
Can't we reuse the other datatype, or ensure in some way that changes in this
other data type will cause compile errors? If not, can we add a unittest
checking for this?

[sdefresne, 2015-05-20 08:11:33]

On 2015/05/19 19:45:01, noyau wrote:
> This class is not tested, and the presence of a mock seems to indicate that it
> is not even indirectly tested by something else. So it probably needs some
> unittest coverage.

It has unit tests downstream. They depends on code that is not upstreamed yet
and thus cannot be upstreamed.

>
https://codereview.chromium.org/1148573002/diff/1/ios/chrome/browser/sync/syn...
> File ios/chrome/browser/sync/sync_setup_service.cc (right):
> 
>
https://codereview.chromium.org/1148573002/diff/1/ios/chrome/browser/sync/syn...
> ios/chrome/browser/sync/sync_setup_service.cc:20: //
> |SyncSetupService::SyncableDatatype|.
> Can't we reuse the other datatype, or ensure in some way that changes in this
> other data type will cause compile errors? If not, can we add a unittest
> checking for this?

[noyau (Ping after 24h), 2015-05-20 09:33:41]

The CQ bit was checked by noyau@chromium.org

[noyau (Ping after 24h), 2015-05-20 09:33:41]

lgtm

[commit-bot: I haz the power, 2015-05-20 09:34:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148573002/1

[commit-bot: I haz the power, 2015-05-20 09:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 09:41:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sdefresne, 2015-05-20 12:34:34]

atwilson: ping?

[sdefresne, 2015-05-20 12:49:19]

sdefresne@chromium.org changed reviewers:
+ zea@chromium.org

[sdefresne, 2015-05-20 12:49:43]

zea: OWNERS approval required for new DEPS on //sync

[Nicolas Zea, 2015-05-20 15:21:50]

lgtm

[sdefresne, 2015-05-20 15:22:37]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-05-20 15:22:47]

Thank you all for the review.

[commit-bot: I haz the power, 2015-05-20 15:22:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148573002/1

[commit-bot: I haz the power, 2015-05-20 15:27:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-20 15:27:54]

Patchset 1 (id:??) landed as
https://crrev.com/5548199bedbf5452f0655aa236bebed3726ea1f2
Cr-Commit-Position: refs/heads/master@{#330736}