Fix all compiler errors found by the new compiler version.

Fix all compiler errors found by the new compiler version.

Bumping closure compiler:

compiler.jar: v20150315-201-g05061ab -> v20150505-49-g22940a8
BUG=
R=dbeam@chromium.org, fukino@chromium.org, kelvinp@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/796417e50f2e8b1a389e28ff62768b03cca982a6

[Jeremy Klein, 2015-05-19 23:01:14]

jlklein@chromium.org changed reviewers:
+ dbeam@chromium.org, fukino@chromium.org, wez@chromium.org

[Jeremy Klein, 2015-05-19 23:01:15]

fukino@ for file_manager changes. FYI: Cache and Request global names conflict
with
https://github.com/google/closure-compiler/commit/fd513f84fecbf83642b1f234c0a....

dbeam@ for compiler ownership.

wez@ for remoting.

[Dan Beam, 2015-05-19 23:10:59]

lgtm

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/device_handler.js (right):

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/device_handler.js:448:
root.getDirectory.bind(root, 'DCIM', {create: false}))
This is up to owners but I don't see how a null |root| would work here...

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/duplicate_finder.js (right):

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/duplicate_finder.js:41: * @param
{Array<string>} urls
Same story

[Wez, 2015-05-19 23:16:00]

wez@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Wez, 2015-05-19 23:16:00]

-wez, +jamiewalch for remoting/

[kelvinp, 2015-05-20 00:22:00]

kelvinp@chromium.org changed reviewers:
+ kelvinp@chromium.org

[kelvinp, 2015-05-20 00:22:00]

lgtm for remoting

[fukino, 2015-05-20 06:31:51]

file_manager lgtm.

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/device_handler.js (right):

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/device_handler.js:442: * @param
{DirectoryEntry} root
I'm not sure why this needs to be {DirectoryEntry}.

volumeInfo.resolveDisplayRoot() returns Promise.<!DirectoryEntry>, so we don't
expect that this |root| can be null. Maybe a compiler issue?

That said, I'm OK with this CL for updating the compiler since this doesn't
change actual code.
I'll take a look about the annotation issue later.

[Jeremy Klein, 2015-05-20 18:23:39]

Got some better type safety in file_manager by adding a couple missing "!"s.

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/device_handler.js (right):

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/device_handler.js:442: * @param
{DirectoryEntry} root
On 2015/05/20 06:31:51, fukino wrote:
> I'm not sure why this needs to be {DirectoryEntry}.
> 
> volumeInfo.resolveDisplayRoot() returns Promise.<!DirectoryEntry>, so we don't
> expect that this |root| can be null. Maybe a compiler issue?
> 
> That said, I'm OK with this CL for updating the compiler since this doesn't
> change actual code.
> I'll take a look about the annotation issue later.

Got this one to work by adding a couple more missing !s

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/device_handler.js:448:
root.getDirectory.bind(root, 'DCIM', {create: false}))
On 2015/05/19 23:10:58, Dan Beam wrote:
> This is up to owners but I don't see how a null |root| would work here...

Acknowledged.

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/duplicate_finder.js (right):

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/duplicate_finder.js:41: * @param
{Array<string>} urls
On 2015/05/19 23:10:58, Dan Beam wrote:
> Same story

Done.

[Jeremy Klein, 2015-05-20 18:23:39]

Got some better type safety in file_manager by adding a couple missing "!"s.

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/device_handler.js (right):

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/device_handler.js:442: * @param
{DirectoryEntry} root
On 2015/05/20 06:31:51, fukino wrote:
> I'm not sure why this needs to be {DirectoryEntry}.
> 
> volumeInfo.resolveDisplayRoot() returns Promise.<!DirectoryEntry>, so we don't
> expect that this |root| can be null. Maybe a compiler issue?
> 
> That said, I'm OK with this CL for updating the compiler since this doesn't
> change actual code.
> I'll take a look about the annotation issue later.

Got this one to work by adding a couple more missing !s

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/device_handler.js:448:
root.getDirectory.bind(root, 'DCIM', {create: false}))
On 2015/05/19 23:10:58, Dan Beam wrote:
> This is up to owners but I don't see how a null |root| would work here...

Acknowledged.

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/background/js/duplicate_finder.js (right):

https://codereview.chromium.org/1148563004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/background/js/duplicate_finder.js:41: * @param
{Array<string>} urls
On 2015/05/19 23:10:58, Dan Beam wrote:
> Same story

Done.

[Jeremy Klein, 2015-05-20 18:23:56]

jlklein@chromium.org changed reviewers:
- jamiewalch@chromium.org, wez@chromium.org

[Jeremy Klein, 2015-05-20 18:24:01]

The CQ bit was checked by jlklein@chromium.org

[Jeremy Klein, 2015-05-20 18:24:02]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org,
dbeam@chromium.org, kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1148563004/#ps40001
(title: "better type fixes")

[commit-bot: I haz the power, 2015-05-20 18:24:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148563004/40001

[commit-bot: I haz the power, 2015-05-20 20:25:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 20:25:26]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Jeremy Klein, 2015-05-22 18:34:49]

FYI kelvinp for remoting: I also had to update chrome_proto.js to compensate for
these compiler changes:

https://github.com/google/closure-compiler/commit/2506719081ab22a356c5ec8ecda...
https://github.com/google/closure-compiler/commit/07a1c8aa36bc021ce591672f8b9...

Which moved some Chrome externs into the compiler itself. I strongly recommend
that you switch to using the supported chrome_extensions.js externs rather than
rolling your own in remoting. You're bound to keep breaking otherwise.

[Jeremy Klein, 2015-05-22 18:34:58]

The CQ bit was checked by jlklein@chromium.org

[Jeremy Klein, 2015-05-22 18:34:58]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
fukino@chromium.org, kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1148563004/#ps60001
(title: "Update again and fix externs issues")

[commit-bot: I haz the power, 2015-05-22 18:36:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1148563004/60001

[commit-bot: I haz the power, 2015-05-22 18:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-22 18:47:14]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[commit-bot: I haz the power, 2015-05-27 05:36:08]

Patchset 6 (id:??) landed as
https://crrev.com/796417e50f2e8b1a389e28ff62768b03cca982a6
Cr-Commit-Position: refs/heads/master@{#331536}

[Jeremy Klein, 2015-05-27 05:36:17]

Committed patchset #6 (id:100001) manually as
796417e50f2e8b1a389e28ff62768b03cca982a6 (presubmit successful).