Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1148543004: Add an OWNERS file to components/renderer_context_menu. (Closed)

Created:
5 years, 7 months ago by msramek
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an OWNERS file to components/renderer_context_menu. This component previously had no OWNERS file. It makes sense to populate OWNERS from this component's counterpart in chrome/, i.e. chrome/browser/renderer_context_menu/OWNERS. Committed: https://crrev.com/5a4fd7ca1f00be3a761dee42df4da84064a9f81f Cr-Commit-Position: refs/heads/master@{#330530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + components/renderer_context_menu/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
msramek
Hi Sylvain, per your suggestion in https://codereview.chromium.org/1142923002/, I'm adding the missing owners file to components/renderer_context_menu. ...
5 years, 7 months ago (2015-05-19 13:06:23 UTC) #2
sdefresne
On 2015/05/19 13:06:23, msramek wrote: > Hi Sylvain, > > per your suggestion in https://codereview.chromium.org/1142923002/, ...
5 years, 7 months ago (2015-05-19 13:23:11 UTC) #3
msramek
On 2015/05/19 13:23:11, sdefresne wrote: > On 2015/05/19 13:06:23, msramek wrote: > > Hi Sylvain, ...
5 years, 7 months ago (2015-05-19 13:28:33 UTC) #4
sdefresne
Good. lgtm
5 years, 7 months ago (2015-05-19 13:32:47 UTC) #5
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-19 14:53:29 UTC) #6
lazyboy
lgtm
5 years, 7 months ago (2015-05-19 15:46:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148543004/1
5 years, 7 months ago (2015-05-19 16:10:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 17:04:38 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:05:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a4fd7ca1f00be3a761dee42df4da84064a9f81f
Cr-Commit-Position: refs/heads/master@{#330530}

Powered by Google App Engine
This is Rietveld 408576698