Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1148523006: Remove unused code in render_frame_impl (Closed)

Created:
5 years, 7 months ago by jrummell
Modified:
5 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code in render_frame_impl blink was updated some time ago to use the new method, so this is simply a cleanup on unused code. TEST=compiles BUG= Committed: https://crrev.com/4be4e35d18c6adef02f25a3cf47a16891beee99a Cr-Commit-Position: refs/heads/master@{#330681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jrummell
PTAL. Simply deleting an unused method.
5 years, 7 months ago (2015-05-19 22:39:59 UTC) #2
nasko
LGTM
5 years, 7 months ago (2015-05-19 23:28:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1148523006/1
5 years, 7 months ago (2015-05-20 00:22:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 02:14:38 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 02:15:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4be4e35d18c6adef02f25a3cf47a16891beee99a
Cr-Commit-Position: refs/heads/master@{#330681}

Powered by Google App Engine
This is Rietveld 408576698